Migrate video description and about channel fragments to Jetpack Compose #11489
Conversation
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
7788a20 to
de6285b
Compare
github-actions
bot
added
size/giant
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
875e3fa to
45aa445
Compare
Isira-Seneviratne
changed the title
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
954770b to
387a4d5
Compare
There was a problem hiding this comment.
Thank you! According to your what you provided, this finally fixes the scrolling issue when selecting text 🎉
In my opinion, the tag chips component isn't the right one. An ElevatedSuggestionChip or something similar would probably look a lot better and similar to the current one used in XML.
Like other metadata items and in the current design, the Tags text should be upper-case.
You should not talk about a video description but a stream description, there are audio-only supported services. So your new VideoDescriptionSection composable and its corresponding package should be renamed :)
| onTextLayout: (TextLayoutResult) -> Unit = {}, | ||
| style: TextStyle = LocalTextStyle.current | ||
| ) { | ||
| // TODO: Handle links and hashtags, Markdown. |
There was a problem hiding this comment.
This must be solved before the PR can be merged.
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
edf3782 to
8f9faf3
Compare
Isira-Seneviratne
force-pushed
the
Video-description-compose
branch
from
8d93272 to
0d12cfc
Compare
ShareASmile
added
rewrite
ShareASmile
removed
the
waiting for review
# Conflicts: # app/build.gradle # app/src/main/java/org/schabi/newpipe/fragments/detail/DescriptionFragment.java # app/src/main/java/org/schabi/newpipe/fragments/list/channel/ChannelAboutFragment.java # app/src/main/java/org/schabi/newpipe/ui/components/items/ItemList.kt # app/src/main/java/org/schabi/newpipe/ui/components/items/stream/StreamMenu.kt
# Conflicts: # app/src/main/java/org/schabi/newpipe/ktx/Bundle.kt
|
|
I suggest three things on this PR:
|
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Screen_recording_20240831_154300.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence