Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake changes to build installers #280

Merged
merged 10 commits into from
Oct 4, 2024

Conversation

ktbolt
Copy link
Collaborator

@ktbolt ktbolt commented Oct 3, 2024

These are primarily CMake code changes to enable building installers using cpack on Ubuntu and MacOS (see #267).

I have also changed the build directory name to svFSIplus-build and the svFSIplus executable to svfsiplus.The test Python scripts have been modified for these changes.

@ktbolt ktbolt requested a review from dcodoni October 3, 2024 17:32
Copy link
Contributor

@dcodoni dcodoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for merging

@mrp089
Copy link
Member

mrp089 commented Oct 4, 2024

@ktbolt, this needs a manual merge with resolving (easy) conflicts since the name of the macos test file changed

@ktbolt ktbolt merged commit 82c9ea6 into SimVascular:main Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants