Skip to content

Commit

Permalink
CMake changes to build installers (#280)
Browse files Browse the repository at this point in the history
* Change file name.

* Turn off including headers and libraries in the install.

* Modify the distribution CMake file to only install the svfsiplus executable.

* Change install for just svfsiplus executable.

* Change build and executable names.

* Remove script commands and change file names.

* Remove Scripts code used to create shell scripts to run svfsiplus.
  • Loading branch information
ktbolt authored Oct 4, 2024
1 parent f55222f commit 82c9ea6
Show file tree
Hide file tree
Showing 32 changed files with 32 additions and 441 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ jobs:
conda run -n svfsiplus pytest -rPv --durations=0
- name: Run unit tests
run: |
cd build/svFSI-build/Source/svFSI
cd build/svFSIplus-build/Source/svFSI
ctest --verbose
6 changes: 3 additions & 3 deletions .github/workflows/test_ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,17 @@ jobs:
conda run -n svfsiplus pytest -rPv --durations=0
- name: Run unit tests
run: |
cd build/svFSI-build/Source/svFSI
cd build/svFSIplus-build/Source/svFSI
ctest --verbose
- name: Generate code coverage
run: |
cd build/svFSI-build
cd build/svFSIplus-build
make coverage
- name: Save coverage report
uses: actions/upload-artifact@v3
with:
name: coverage_report
path: build/svFSI-build/coverage
path: build/svFSIplus-build/coverage
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
env:
Expand Down
5 changes: 3 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ endif()

#-----------------------------------------------------------------------------
Project(SV_TOP)
message(STATUS "SV_TOP: ${SV_TOP}")
#-----------------------------------------------------------------------------

#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -124,9 +125,9 @@ set(SV_EXTERNALS_TOPLEVEL_DIR "${CMAKE_BINARY_DIR}/Externals-build/sv_externals"
# svFSIplus solver.
set(SV_ADDITIONAL_CMAKE_ARGS "" CACHE STRING "If more options want to be provided to the sv_externals build, they can be with this string")
set(SV_APPLE_CMAKE_ARGS)
ExternalProject_Add(svFSI
ExternalProject_Add(svFSIplus
SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/Code
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/svFSI-build
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/svFSIplus-build
DEPENDS Externals
DOWNLOAD_COMMAND ""
UPDATE_COMMAND ""
Expand Down
13 changes: 10 additions & 3 deletions Code/CMake/SimVascularDependentOptions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,16 @@ endif()
#-----------------------------------------------------------------------------
# Shared Libs
#-----------------------------------------------------------------------------
set(SV_INSTALL_HEADERS ON)
set(SV_INSTALL_EXTERNALS ON)
set(SV_INSTALL_LIBS ON)

set(SV_INSTALL_HEADERS OFF)
#set(SV_INSTALL_HEADERS ON)

set(SV_INSTALL_EXTERNALS OFF)
#set(SV_INSTALL_EXTERNALS ON)

set(SV_INSTALL_LIBS OFF)
#set(SV_INSTALL_LIBS ON)

if(BUILD_SHARED_LIBS)
set(SV_LIBRARY_TYPE "SHARED" CACHE STRING "Shared cache" FORCE)
set(SV_STATIC_BUILD "0")
Expand Down
9 changes: 2 additions & 7 deletions Code/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ include(SimVascularDependentOptions)
include(SimVascularInstallSetup)

#set(SV_USE_TRILINOS {SV_USE_TRILINOS} PARENT_SCOPE)
#set(SV_USE_TRILINOS OFF CACHE INTERNAL BOOL "Use Trilinos Library with svFSI")
#set(SV_USE_TRILINOS OFF CACHE INTERNAL BOOL "Use Trilinos Library with svFSIplus")
#set(SV_USE_TRILINOS OFF CACHE BOOL INTERNAL)

#-----------------------------------------------------------------------------

#-----------------------------------------------------------------------------
# Set EXE names for the executables
set(SV_SVFSI_EXE "svFSI")
set(SV_SVFSI_EXE "svfsiplus")
#-----------------------------------------------------------------------------

#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -159,8 +159,3 @@ if(SV_ENABLE_DISTRIBUTION)
endif()
#-----------------------------------------------------------------------------

#-----------------------------------------------------------------------------
# Configure Exe Scripts, this should be the last subdirectory
include(SimVascularInstallLibs)
add_subdirectory(Scripts)
#-----------------------------------------------------------------------------
116 changes: 0 additions & 116 deletions Code/Scripts/CMakeLists.txt

This file was deleted.

26 changes: 0 additions & 26 deletions Code/Scripts/README-install

This file was deleted.

3 changes: 0 additions & 3 deletions Code/Scripts/README-postinstall

This file was deleted.

151 changes: 0 additions & 151 deletions Code/Scripts/SimVascularScriptMacros.cmake

This file was deleted.

Loading

0 comments on commit 82c9ea6

Please sign in to comment.