Solid viscosity default value bug #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (which sets the fluid viscosity parameter and therefore has no effect)
aabrown100-git
added a commit
to SimVascular/simvascular.github.io
that referenced
this pull request
Sep 10, 2024
To be consistent with SimVascular/svFSIplus#270
1 task
|
@aabrown100-git Using default values is a bad practice svfsiplus inherited from svfsi. At some point I would like to remove using default values for parameters. |
ktbolt
reviewed
Sep 10, 2024
divyaadil23
approved these changes
Sep 19, 2024
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
#269
Release Notes
solid_viscosityto 0.0 (from 0.9)struct,ustruct, andfsitest casesDocumentation
I have an open pull request to update the documentation.
Testing
Updated test reference solutions affected by this change.
Code of Conduct & Contributing Guidelines