Solid viscosity default value bug (#270)

* Change solid_viscosity default value to 0.0 * Update test case reference results, remove Viscosity in some xml files (which sets the fluid viscosity parameter and therefore has no effect)
SimVascular · Sep 26, 2024 · aca9a10 · aca9a10
1 parent 825872a
commit aca9a10
Show file tree

Hide file tree

Showing 24 changed files with 35 additions and 53 deletions.
diff --git a/Code/Source/svFSI/Parameters.cpp b/Code/Source/svFSI/Parameters.cpp
@@ -1299,7 +1299,7 @@ DomainParameters::DomainParameters()
  set_parameter("Relative_tolerance", 1e-4, !required, relative_tolerance);
  set_parameter("Shell_thickness", 0.0, !required, shell_thickness);
  set_parameter("Solid_density", 0.5, !required, solid_density);
- set_parameter("Solid_viscosity", 0.9, !required, solid_viscosity);
+ set_parameter("Solid_viscosity", 0.0, !required, solid_viscosity);
  set_parameter("Source_term", 0.0, !required, source_term);
  set_parameter("Time_step_for_integration", 0.0, !required, time_step_for_integration);
 }

diff --git a/tests/cases/fsi/pipe_3d/result_005.vtu b/tests/cases/fsi/pipe_3d/result_005.vtu
diff --git a/tests/cases/fsi/pipe_3d_petsc/result_005.vtu b/tests/cases/fsi/pipe_3d_petsc/result_005.vtu
diff --git a/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu b/tests/cases/fsi/pipe_3d_trilinos_bj/result_005.vtu
diff --git a/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu b/tests/cases/fsi/pipe_3d_trilinos_ml/result_005.vtu
diff --git a/tests/cases/struct/LV_Guccione_passive/result_001.vtu b/tests/cases/struct/LV_Guccione_passive/result_001.vtu
diff --git a/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu b/tests/cases/struct/LV_Holzapfel_passive/result_001.vtu
diff --git a/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml b/tests/cases/struct/LV_Holzapfel_passive/svFSIplus.xml
@@ -58,9 +58,6 @@
  <Density> 1.0 </Density> <!-- g/cm^3 -->
  <Elasticity_modulus> 1.0e6 </Elasticity_modulus> <!-- dyne/cm^2 -->
  <Poisson_ratio> 0.483333 </Poisson_ratio>
- <Viscosity model="Constant" >
- <Value> 0.0 </Value>
- </Viscosity>
 
  <Constitutive_model type="Holzapfel"> 
  <a> 590.0 </a> <!-- dyne/cm^2 -->

diff --git a/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu b/tests/cases/struct/LV_NeoHookean_passive/result_005.vtu
diff --git a/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml b/tests/cases/struct/LV_NeoHookean_passive/svFSIplus.xml
@@ -59,9 +59,6 @@
  <Constitutive_model type="neoHookean"> 
  </Constitutive_model> 
  <Dilational_penalty_model> ST91 </Dilational_penalty_model>
- <Viscosity model="Constant" >
- <Value> 0.0 </Value>
- </Viscosity>
 
 
  <Output type="Spatial" >

diff --git a/tests/cases/struct/LV_NeoHookean_passive_genBC/result_003.vtu b/tests/cases/struct/LV_NeoHookean_passive_genBC/result_003.vtu
diff --git a/tests/cases/struct/LV_NeoHookean_passive_genBC/svFSIplus.xml b/tests/cases/struct/LV_NeoHookean_passive_genBC/svFSIplus.xml
@@ -59,9 +59,6 @@
  <Constitutive_model type="neoHookean"> 
  </Constitutive_model> 
  <Dilational_penalty_model> ST91 </Dilational_penalty_model>
- <Viscosity model="Constant" >
- <Value> 0.0 </Value>
- </Viscosity>
 
 
  <Output type="Spatial" >

diff --git a/tests/cases/struct/LV_NeoHookean_passive_sv0D/result_003.vtu b/tests/cases/struct/LV_NeoHookean_passive_sv0D/result_003.vtu
diff --git a/tests/cases/struct/LV_NeoHookean_passive_sv0D/svFSIplus.xml b/tests/cases/struct/LV_NeoHookean_passive_sv0D/svFSIplus.xml
@@ -59,9 +59,6 @@
  <Constitutive_model type="neoHookean"> 
  </Constitutive_model> 
  <Dilational_penalty_model> ST91 </Dilational_penalty_model>
- <Viscosity model="Constant" >
- <Value> 0.0 </Value>
- </Viscosity>
 
 
  <Output type="Spatial" >

diff --git a/tests/cases/struct/block_compression/result_001.vtu b/tests/cases/struct/block_compression/result_001.vtu
diff --git a/tests/cases/struct/robin/result_001.vtu b/tests/cases/struct/robin/result_001.vtu
diff --git a/tests/cases/struct/tensile_adventitia_Guccione_active/result_002.vtu b/tests/cases/struct/tensile_adventitia_Guccione_active/result_002.vtu
diff --git a/tests/cases/ustruct/LV_Guccione_active/result_001.vtu b/tests/cases/ustruct/LV_Guccione_active/result_001.vtu
diff --git a/tests/cases/ustruct/LV_NeoHookean_passive_genBC/result_003.vtu b/tests/cases/ustruct/LV_NeoHookean_passive_genBC/result_003.vtu
diff --git a/tests/cases/ustruct/LV_NeoHookean_passive_genBC/svFSIplus.xml b/tests/cases/ustruct/LV_NeoHookean_passive_genBC/svFSIplus.xml
@@ -59,9 +59,6 @@
  <Constitutive_model type="neoHookean"> 
  </Constitutive_model> 
  <Dilational_penalty_model> ST91 </Dilational_penalty_model>
- <Viscosity model="Constant" >
- <Value> 0.0 </Value>
- </Viscosity>
 
 
  <Output type="Spatial" >

diff --git a/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/result_003.vtu b/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/result_003.vtu
diff --git a/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/svFSIplus.xml b/tests/cases/ustruct/LV_NeoHookean_passive_sv0D/svFSIplus.xml
@@ -59,9 +59,6 @@
  <Constitutive_model type="neoHookean"> 
  </Constitutive_model> 
  <Dilational_penalty_model> ST91 </Dilational_penalty_model>
- <Viscosity model="Constant" >
- <Value> 0.0 </Value>
- </Viscosity>
 
 
  <Output type="Spatial" >

diff --git a/tests/cases/ustruct/block_compression/P1P1_VMS/result_001.vtu b/tests/cases/ustruct/block_compression/P1P1_VMS/result_001.vtu
diff --git a/tests/cases/ustruct/tensile_adventitia_HGO/result_001.vtu b/tests/cases/ustruct/tensile_adventitia_HGO/result_001.vtu