-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Themes] Add support for theme blocks in theme package
command
#5158
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success1994 tests passing in 902 suites. Report generated by 🧪jest coverage report action from 9d47c0f |
0667288
to
9d47c0f
Compare
theme package
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
/shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks James! just curious, why was CI failing on the original PR?
I didn't have time to dig into exactly why CI was failing - it could be either due to an outdated branch (needs rebase, or due to the branch coming from a forked version of the Repo. I suspect we would have to investigate the actions themselves. My money is on the latter, though I'm optimistically hoping that it's the former reason. |
WHY are these changes introduced?
This is a port / copy of @montalvomiguelo's original PR #5139 - Opened a new branch here to remediate CI failures
Fixes #5135
WHAT is this pull request doing?
Adds support for packaging theme blocks by including the
blocks/**
pattern in the theme files pattern list. This ensures that block files are properly included when packaging themes.How to test your changes?
blocks/
directorytheme package
commandblocks/product-grid.liquid
)Measuring impact
Checklist