Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Themes] Add support for theme blocks in theme package command #5158

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

jamesmengo
Copy link
Contributor

@jamesmengo jamesmengo commented Jan 6, 2025

WHY are these changes introduced?

This is a port / copy of @montalvomiguelo's original PR #5139 - Opened a new branch here to remediate CI failures

Fixes #5135

WHAT is this pull request doing?

Adds support for packaging theme blocks by including the blocks/** pattern in the theme files pattern list. This ensures that block files are properly included when packaging themes.

How to test your changes?

  1. Create a theme with blocks in the blocks/ directory
  2. Run the theme package command
  3. Verify that block filess are included in the packaged output
  4. Test with a sample block file (e.g., blocks/product-grid.liquid)

Measuring impact

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.31% 8841/11740
🟡 Branches 70.56% 4290/6080
🟡 Functions 75.21% 2315/3078
🟡 Lines
75.85% (+0.01% 🔼)
8358/11019
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
90.48% 98.61%

Test suite run success

1994 tests passing in 902 suites.

Report generated by 🧪jest coverage report action from 9d47c0f

@jamesmengo jamesmengo force-pushed the jm/theme-package-blocks branch from 0667288 to 9d47c0f Compare January 6, 2025 22:32
@jamesmengo jamesmengo changed the title Allow packaging theme blocks [Themes] Add support for theme blocks in theme package command Jan 6, 2025
@jamesmengo jamesmengo marked this pull request as ready for review January 6, 2025 22:34
@jamesmengo jamesmengo requested review from a team as code owners January 6, 2025 22:34
@jamesmengo jamesmengo self-assigned this Jan 6, 2025
Copy link
Contributor

@aswamy aswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesmengo jamesmengo enabled auto-merge January 6, 2025 22:40
@jamesmengo
Copy link
Contributor Author

/shipit

Copy link
Contributor

@gracejychang gracejychang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks James! just curious, why was CI failing on the original PR?

@jamesmengo
Copy link
Contributor Author

I didn't have time to dig into exactly why CI was failing - it could be either due to an outdated branch (needs rebase, or due to the branch coming from a forked version of the Repo. I suspect we would have to investigate the actions themselves.

My money is on the latter, though I'm optimistically hoping that it's the former reason.

@jamesmengo jamesmengo added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 9da5aca Jan 7, 2025
28 checks passed
@jamesmengo jamesmengo deleted the jm/theme-package-blocks branch January 7, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: theme package does not package theme blocks
4 participants