Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shopify theme package to support theme blocks #5139

Closed

Conversation

montalvomiguelo
Copy link
Contributor

WHY are these changes introduced?

Fixes #5135

WHAT is this pull request doing?

Updates shopify theme package to support theme blocks.

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@montalvomiguelo montalvomiguelo requested review from a team as code owners December 22, 2024 23:22
Copy link
Contributor

@aswamy aswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as described. Thanks for the fix 👍 🎩

@jamesmengo
Copy link
Contributor

Hey @montalvomiguelo!
Thanks for these changes, it's awesome seeing the community come together to help each other out.

I'm hoping to roll this out in tomorrow's release, so I created a duplicate PR here with your changes + attribution so that I could address any CI failures. Let's use that PR instead for this change.

Thank you so much for your contribution, it's greatly appreciated!

@jamesmengo jamesmengo closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: theme package does not package theme blocks
4 participants