Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme generation commands for blocks, sections, and templates #5081

Draft
wants to merge 14 commits into
base: jm/framework_theme
Choose a base branch
from

Conversation

jamesmengo
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

jamesmengo commented Dec 11, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Unused types (3)

Filename types
packages/theme/src/cli/services/generate/blocks.ts BlockGeneratorOptions
packages/theme/src/cli/services/generate/sections.ts SectionGeneratorOptions
packages/theme/src/cli/services/generate/templates.ts TemplateGeneratorOptions

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.33% (-0.01% 🔻)
8837/11731
🟡 Branches
70.61% (-0.02% 🔻)
4290/6076
🟡 Functions 75.2% 2314/3077
🟡 Lines
75.87% (-0.01% 🔻)
8354/11011
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

1994 tests passing in 900 suites.

Report generated by 🧪jest coverage report action from 74e4ca3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant