[Themes] Add TODOs for template generator improvements

Shopify · Dec 20, 2024 · 74e4ca3 · 74e4ca3
1 parent c1d608c
commit 74e4ca3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/packages/theme/src/cli/services/generate/sections.ts b/packages/theme/src/cli/services/generate/sections.ts
@@ -19,6 +19,8 @@ export const JSON_SECTION_HEADER = `/*
  * ------------------------------------------------------------
  */`
 
+// TODO: move name / path resolution logic upstream
+// TODO: Rather than throwing an error here we should prompt for name upstream
 export async function generateSection(options: SectionGeneratorOptions) {
   const sectionPath = joinPath(options.path, 'sections', `${options.name}.${options.fileType}`)
 

diff --git a/packages/theme/src/cli/services/generate/templates.ts b/packages/theme/src/cli/services/generate/templates.ts
@@ -3,6 +3,8 @@ import {writeFile, readFile, fileExists} from '@shopify/cli-kit/node/fs'
 import {joinPath} from '@shopify/cli-kit/node/path'
 import {outputInfo} from '@shopify/cli-kit/node/output'
 
+// TODO: move name / path resolution logic upstream
+// TODO: add type flag
 export interface TemplateGeneratorOptions {
   name: string | undefined
   path: string