[Theme] Fix cart requests #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1890 tests passing in 858 suites. Report generated by 🧪jest coverage report action from fa91638 |
|
It fixes #4510 as well, let's ship this fix 🚀 4510.mp4 |
|
@montalvomiguelo You can use this version until an official release is out: #4494 (comment) (or use the nightly release listed on NPM) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes #4488
WHAT is this pull request doing?
The h3 utility we were using for headers was removing
acceptheader. The cart requests needaccept: application/javascript(cart/add) andapplication/json(cart/change) to work in SFR. Since this header was removed, it was responding with either 302 or 401.How to test your changes?
Add an item to cart with and without the changes in this PR.
cc @Shopify/advanced-edits