Fix cart requests in the local proxy to avoid 401-Unauthorized errors #4570
+63
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fix the scenario involving the remove button described by:
(the checkout piece is not part of the scope of this PR)
WHAT is this pull request doing?
This PR fixes the 401-Unauthorized errors involving cart requests by proxying them instead of relying on the SFR-remote-renderer client. The code is very declarative, but I've added some tests to document the intention.
How to test your changes?
shopify theme init
HTMLAnchorElement
to remove a cart item<a href="{{ item.url_to_remove }}">Remove</a>
(as described by #4488)Before
After
Post-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist