Applied general fixes from PR 667 #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescalb
reviewed
Dec 1, 2023
| @@ -60,7 +60,7 @@ class TransformationStatus(BaseModel): | |||
| assert inst.startTime == int(now - 3000) | |||
| utc = timezone(timedelta(hours=0)) | |||
| dt = datetime.fromtimestamp(now - 600).astimezone(utc) | |||
| assert inst.finishTime == str(dt) | |||
| assert inst.finishTime.split("+")[0] == str(dt).split("+")[0] | |||
francescalb
reviewed
Dec 1, 2023
cmake/valgrind-python.supp
Outdated
There was a problem hiding this comment.
Describe the purpose of this.
francescalb
reviewed
Dec 1, 2023
src/dlite-storage-plugins.c
Outdated
There was a problem hiding this comment.
To avoid memory leak by calling fu_endmatch() when we are done with the iterator.
To not polute the code with unnecessary comments, I prefer not to add this comment to the code since it is already documented in fu_startmatch() that the returned iterator must be cleaned up with fu_endmatch().
francescalb
reviewed
Dec 1, 2023
storages/json/dlite-json-storage.c
Outdated
There was a problem hiding this comment.
Changed name of variable from "state" to "globals" to be consistent with variable naming when get_dlite_storage_plugin_api() is called in the rest of the code.
I also think this comment belongs better here than in the code.
7 tasks
francescalb
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied general improvements from PR 667.
The purpose of this PR is to ensure that the fixes in PR 667 are not lost. This includes
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.