Move test input/output to separate directories #609
Comments
|
PR #720 addresses this for two tests in binding/python/tests/ |
This was referenced Dec 2, 2023
jesper-friis
added a commit
that referenced
this issue
Dec 6, 2023
# Description Applied general improvements from PR 667. The purpose of this PR is to ensure that the fixes in PR 667 are not lost. This includes - save test output in a separate directory (for some tests, see issue #609) - do not run test_property_mappings if rdflib is missing - documented environment variable DLITE_ATEXIT_FREE - fixed memory leak in test_bson_storage Explanation of some of the changes can be found on #720 ## Type of change - [x] Bug fix & code cleanup - [ ] New feature - [ ] Documentation update - [ ] Test update ## Checklist for the reviewer This checklist should be used as a help for the reviewer. - [ ] Is the change limited to one issue? - [ ] Does this PR close the issue? - [ ] Is the code easy to read and understand? - [ ] Do all new feature have an accompanying new test? - [ ] Has the documentation been updated as necessary?
jesper-friis
added a commit
that referenced
this issue
Jan 24, 2024
# Description Moved entities, input and output files to respectively sub-directories in the Python tests. Closes #689 Addresses also issue #609 While updating the tests to use the new sub-directories, a few other path-related issues were discovered and fixed: * two potential segfaults in dlite-storage.i and dlite.rdf.c if an invalid path is provided were fixed * raise DLiteParseError instead of DLiteOtherError for invalid json input * allow to hide DLiteOtherError by using DLiteUnknownError. ## Type of change - [x] Bug fix & code cleanup - [ ] New feature - [ ] Documentation update - [ ] Test update ## Checklist for the reviewer This checklist should be used as a help for the reviewer. - [ ] Is the change limited to one issue? - [ ] Does this PR close the issue? - [ ] Is the code easy to read and understand? - [ ] Do all new feature have an accompanying new test? - [ ] Has the documentation been updated as necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently running the tests pollutes the current directory with a lot of test output files. To avoid this, write test output to a
outputsub-directory of the test directory.It would also be easier to spot test input if they are moved to a
inputsub-directory of the test directory.Test directories that should be fixed:
The text was updated successfully, but these errors were encountered: