Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test entities and input and output files to sub-directories #731

Merged
merged 11 commits into from
Jan 24, 2024

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Dec 2, 2023

Description

Moved entities, input and output files to respectively sub-directories in the Python tests.

Closes #689
Addresses also issue #609

While updating the tests to use the new sub-directories, a few other path-related issues were discovered and fixed:

  • two potential segfaults in dlite-storage.i and dlite.rdf.c if an invalid path is provided were fixed
  • raise DLiteParseError instead of DLiteOtherError for invalid json input
  • allow to hide DLiteOtherError by using DLiteUnknownError.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@jesper-friis jesper-friis linked an issue Dec 2, 2023 that may be closed by this pull request
@jesper-friis jesper-friis changed the title Moved entities, input and output files to respectively sub-directories. Move test entities and input and output files to sub-directories Dec 9, 2023
@jesper-friis jesper-friis removed the request for review from francescalb January 10, 2024 08:29
@jesper-friis jesper-friis merged commit ece8707 into master Jan 24, 2024
12 checks passed
@jesper-friis jesper-friis deleted the 689-entities-folder branch January 24, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all entities used for tests in the entities folder
1 participant