Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: publish correct package types #7451

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: publish correct package types #7451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2d0b12
chore: publish correct package types
benlesh Feb 29, 2024
e6178f8
chore: fix bad reference in browser import test
benlesh Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@ typings/
# Generated
dist/
.tshy-build
.tshy
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the files under .tshy are apparently generated on every build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool, I purely based it on the tshy repo itself having that folder checked in https://github.com/isaacs/tshy

@isaacs sorry for the direct ping but do you have the official view on this please? Is there any disadvantage to ignoring it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually check it in because I use the tsconfig files tshy generates in order to run tests and build docs in CI. But you can check it in or not, as you see fit. Whenever you build, tshy will re-generate those files as needed anyhow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isaacs!


# Import location artifacts
packages/rxjs/ajax/
Expand Down
12 changes: 0 additions & 12 deletions packages/observable/.tshy/browser.json
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions packages/observable/.tshy/build.json
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions packages/observable/.tshy/commonjs.json
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions packages/observable/.tshy/esm.json
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions packages/observable/.tshy/webpack.json
View file
Open in desktop

This file was deleted.

16 changes: 1 addition & 15 deletions packages/observable/package.json
View file
Open in desktop
Expand Up @@ -38,25 +38,11 @@
"exports": {
"./package.json": "./package.json",
".": "./src/index.ts"
},
"esmDialects": [
"browser"
],
"commonjsDialects": [
"webpack"
]
}
},
"exports": {
"./package.json": "./package.json",
".": {
"browser": {
"types": "./dist/browser/index.d.ts",
"default": "./dist/browser/index.js"
},
"webpack": {
"types": "./dist/webpack/index.d.ts",
"default": "./dist/webpack/index.js"
},
"import": {
"types": "./dist/esm/index.d.ts",
"default": "./dist/esm/index.js"
Expand Down
2 changes: 1 addition & 1 deletion packages/rxjs/integration/import/fixtures/browser/index.html
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
<script type="importmap">
{
"imports": {
"@rxjs/observable": "./node_modules/@rxjs/observable/dist/browser/index.js"
"@rxjs/observable": "./node_modules/@rxjs/observable/dist/esm/index.js"
}
}
</script>
Expand Down