chore: publish correct package types #7451
Conversation
benlesh
commented
Feb 29, 2024
benlesh
commented
- Also removes generated .tshy directory from source control
- Also removes generated .tshy directory from source control
| @@ -13,6 +13,7 @@ typings/ | |||
| # Generated | |||
| dist/ | |||
| .tshy-build | |||
| .tshy | |||
There was a problem hiding this comment.
the files under .tshy are apparently generated on every build.
There was a problem hiding this comment.
Ok cool, I purely based it on the tshy repo itself having that folder checked in https://github.com/isaacs/tshy
@isaacs sorry for the direct ping but do you have the official view on this please? Is there any disadvantage to ignoring it?
There was a problem hiding this comment.
I usually check it in because I use the tsconfig files tshy generates in order to run tests and build docs in CI. But you can check it in or not, as you see fit. Whenever you build, tshy will re-generate those files as needed anyhow.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e6178f8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
