Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphans for V2 #684

Merged
merged 8 commits into from
Jun 23, 2024
Merged

Orphans for V2 #684

merged 8 commits into from
Jun 23, 2024

Conversation

kozross
Copy link
Contributor

@kozross kozross commented Jun 19, 2024

Closes #681. This will need to be updated in PR #679 for V3 versions of the types in question.

SeungheonOh
SeungheonOh previously approved these changes Jun 19, 2024
Copy link
Collaborator

@SeungheonOh SeungheonOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some questions only

bladyjoker
bladyjoker previously approved these changes Jun 20, 2024
Copy link
Collaborator

@bladyjoker bladyjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what happens when you generate some TxInfo fields

data TxInfo = TxInfo
    { txInfoInputs          :: [TxInInfo] -- ^ NON EMPTY Map TxOutRef TxInInfo (NOT A LIST)
    , txInfoReferenceInputs :: [TxInInfo] -- ^ Same as above
    , txInfoOutputs         :: [TxOut] -- ^ Anything goes but Value must have positive ADA
    , txInfoFee             :: Value -- ^ This MUST be ONLY ADA
    , txInfoMint            :: Value -- ^ This contains 0 ADA
    , txInfoDCert           :: [DCert] -- ^ Not sure but I suspect this is also a Map of sorts
    , txInfoWdrl            :: Map StakingCredential Integer
    , txInfoValidRange      :: POSIXTimeRange -- ^ End MUST be after begginning (shock and disbelief).
    , txInfoSignatories     :: [PubKeyHash] -- ^ This is NOT a LIST this is a Set PubKeyHash
    , txInfoRedeemers       :: Map ScriptPurpose Redeemer
    , txInfoData            :: Map DatumHash Datum
    , txInfoId              :: TxId
    } 

plutarch-orphanage/src/PlutusLedgerApi/V2/Orphans.hs Outdated Show resolved Hide resolved
plutarch-orphanage/src/PlutusLedgerApi/V2/Orphans.hs Outdated Show resolved Hide resolved
plutarch-orphanage/src/PlutusLedgerApi/V2/Orphans.hs Outdated Show resolved Hide resolved
plutarch-orphanage/src/PlutusLedgerApi/V2/Orphans.hs Outdated Show resolved Hide resolved
plutarch-orphanage/src/PlutusLedgerApi/V2/Orphans.hs Outdated Show resolved Hide resolved
plutarch-orphanage/src/PlutusLedgerApi/V2/Orphans.hs Outdated Show resolved Hide resolved
@kozross kozross dismissed stale reviews from bladyjoker and SeungheonOh via e41157a June 20, 2024 22:31
Copy link
Collaborator

@bladyjoker bladyjoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TxInfo list/map/set invariants are missing right? You want to add these in some other PR?

@SeungheonOh SeungheonOh merged commit 1a5bd61 into staging Jun 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants