Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor planet XML load #1062

Merged
merged 7 commits into from
Oct 5, 2021
Merged

Refactor planet XML load #1062

merged 7 commits into from
Oct 5, 2021

Commits on Oct 4, 2021

  1. Update parsePlanetAttribute for loop to iterate elements

    @DanRStevens
    DanRStevens committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    690ccbc View commit details
    Browse the repository at this point in the history

  2. Remove no longer needed check for Planet elements 

    The for loop update ensures we only loop over Planet elements.
    @DanRStevens
    DanRStevens committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    53a8c48 View commit details
    Browse the repository at this point in the history

  3. Remove no longer needed toElement() call 

    The for loop update ensures we only loop over Elements, rather than the
more generic Node.
    @DanRStevens
    DanRStevens committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    c328544 View commit details
    Browse the repository at this point in the history

  4. Update parsePlanet for loop to iterate elements

    @DanRStevens
    DanRStevens committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    783e550 View commit details
    Browse the repository at this point in the history

  5. Remove no longer needed toElement() call 

    The for loop will now only iterate over Elements, rather than the Node
base type.
    @DanRStevens
    DanRStevens committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    4f582c8 View commit details
    Browse the repository at this point in the history

  6. Update PlanetAttribute parsing to use Dictionary

    @DanRStevens
    DanRStevens committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    cd3a075 View commit details
    Browse the repository at this point in the history

  7. Remove no longer used function parseElementValue

    @DanRStevens
    DanRStevens committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    5d8c7d5 View commit details
    Browse the repository at this point in the history