Refactor planet XML load #1062
Merged
Refactor planet XML load #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The for loop update ensures we only loop over Planet elements.
The for loop update ensures we only loop over Elements, rather than the more generic Node.
The for loop will now only iterate over Elements, rather than the Node base type.
|
Looks much cleaner than how I originally wrote it. I like how the concept of pulling string data from either a element or an attribute is now possible which made reading the description string trivial in code. |
|
Technically it uses custom code for Planet data loading, so it only supports sub-elements here, and not attributes. Took me a moment to remember this code was different. I originally tried to write the code assuming it was using attributes, which didn't exactly work. Thankfully it was a fairly small change to fix it from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #830
Refactor Planet XML loading code so
forloops only iterate overXmlElementobjects, and to make use ofDictionary.