Send small variables to storage without blob storage #8897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getting size of twin object before client uploading dataset
madhavajay
reviewed
Jun 11, 2024
shubham3121
changed the title
…s less than `min_size_mb` (16 Mb by default)
…data is less than the min size to save to blob storage
…ActionDataEmpty when current thread is not tracing
…n an env varialbe - print out this min size in dev mode when launching nodes
…ge to node and `BlobStorageConfig` - only pass the min size as an env varialbe so it can be read by both the client / server and can easily be configured by the client Co-authored-by: Shubham Gupta <[email protected]>
…tings` and `BlobStorageConfig` which then is passed into a `Node` - `Node` then pass this information around by `NodeMetadata` / `NodeMetadataJSON` - Update utility methods to see if a client can upload an object to the blob storage - Modify test in `blob_storage_test` to reflect these changes Co-authored-by: Shubham Gupta <[email protected]>
…a try-catch - if can't save the data to blob store, save the data to `syft_action_data_cache`
khoaguin
changed the title
|
onhold for now. Merge this later after this pr: |
…e object is small and not saved to the blob store - passing flags telling action service to not clear the cache data of these small objects
…e` in `ActionObject.send`
… in `ActionObject.execute`
…b store / clear cache
4 tasks
shubham3121
reviewed
Jul 2, 2024
shubham3121
reviewed
Jul 2, 2024
shubham3121
reviewed
Jul 2, 2024
shubham3121
reviewed
Jul 2, 2024
shubham3121
requested changes
Jul 2, 2024
…o save to blob store - moving / remove some checks Co-authored-by: Shubham Gupta <[email protected]>
|
Thank you very much for the review, @shubham3121. I changed accordingly |
shubham3121
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/OpenMined/Heartbeat/issues/1274
ActionObjectto blob storage if it is bigger than amin_sizevariable (e.g. 16 MB)MIN_SIZE_BLOB_STORAGE_MB) so it can be configured when we change database implementationsActionObjectbigger thanMIN_SIZE_BLOB_STORAGE_MBand smaller thanMIN_SIZE_BLOB_STORAGE_MB