Dataset and Action Object Deletion APIs #9004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction object - refactor `BlobStorageService.delete` - add placeholder for test cases
…dataset - add a test for deleting dataset
…-actionobj-delete-apis
…-actionobj-delete-apis
…entries for `Asset`
…t's mock and data - add test cases for deleting small (no blob store) and big datasets (with blob store) - modify blob_storage_test accordingly to new changes
- change tutorial notebook accordingly
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
khoaguin
changed the title
…ate_with_dataset`
…` since it's not needed
- rename _delete_blob_entry to _delete_blob_storage_entry
shubham3121
requested changes
Jul 8, 2024
shubham3121
reviewed
Jul 12, 2024
shubham3121
reviewed
Jul 12, 2024
to be consistent with SyftWorker.to_be_deleted
domain has been renamed to datasite
…to action service Co-authored-by: Kien Dang <[email protected]>
shubham3121
reviewed
Jul 15, 2024
shubham3121
reviewed
Jul 15, 2024
shubham3121
reviewed
Jul 15, 2024
shubham3121
reviewed
Jul 15, 2024
…ut deleting its assets - update a dataset's repr if it was deleted - modify respective tests
…g its `syft_action_data_cache` and `syft_action_saved_to_blob_store` to None Co-authored-by: Shubham Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes this issue and this issue. Should be merged after this PR.
Make a high and low side. Then if we delete a dataset on the high side, check if all a syncing functionalities still work and report everything broken to add new ticket if it breaks (not within scope)