Bugfix: Mage_Core_Controller_Front_Router::getUrl()

.phpstan.dist.baseline.neon

@@ -2915,11 +2915,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Core/Controller/Front/Router.php
 
-		-
-			message: "#^Parameter \\#1 \\$type of static method Mage\\:\\:getBaseUrl\\(\\) expects string, array given\\.$#"
-			count: 1
-			path: app/code/core/Mage/Core/Controller/Front/Router.php
-
 		-
 			message: "#^Constructor of class Mage_Core_Controller_Varien_Action has an unused parameter \\$invokeArgs\\.$#"
 			count: 1

app/Mage.php

@@ -444,7 +444,7 @@ public static function getStoreConfigFlag($path, $store = null)
     /**
      * Get base URL path by type
      *
-     * @param string $type
+     * @param Mage_Core_Model_Store::URL_TYPE_* $type
      * @param null|bool $secure
      * @return string
      */

app/code/core/Mage/Core/Controller/Front/Router.php

@@ -53,9 +53,9 @@ public function addRoutes(Zend_Controller_Router_Interface $router)
     }
 
     /**
-     * @param array $params
+     * @param string|array $params
      * @return string
-     */
+-     */
     public function getUrl($params = [])
     {
         static $reservedKeys = ['module' => 1, 'controller' => 1, 'action' => 1, 'array' => 1];
@@ -65,7 +65,7 @@ public function getUrl($params = [])
             $params = ['controller' => $paramsArr[0], 'action' => $paramsArr[1]];
         }
 
-        $url = Mage::getBaseUrl($params);
+        $url = Mage::getBaseUrl();
 
         if (!empty($params['frontName'])) {
             $url .= $params['frontName'] . '/';

app/code/core/Mage/Core/Model/Store.php

@@ -571,7 +571,7 @@ public function getUrl($route = '', $params = [])
     /**
      * Retrieve base URL
      *
-     * @param string $type
+     * @param self::URL_TYPE_* $type
      * @param bool|null $secure
      * @return string
      */

tests/unit/Mage/Core/Controller/Front/RouterTest.php

@@ -0,0 +1,44 @@
+<?php
+
+/**
+ * OpenMage
+ *
+ * This source file is subject to the Open Software License (OSL 3.0)
+ * that is bundled with this package in the file LICENSE.txt.
+ * It is also available at https://opensource.org/license/osl-3-0-php
+ *
+ * @category   OpenMage
+ * @package    OpenMage_Tests
+ * @copyright  Copyright (c) 2024 The OpenMage Contributors (https://www.openmage.org)
+ * @license    https://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
+ */
+
+declare(strict_types=1);
+
+namespace OpenMage\Tests\Unit\Mage\Core\Controller\Front;
+
+use Mage;
+use Mage_Core_Controller_Front_Router;
+use Mage_Core_Model_Config_Element;
+use PHPUnit\Framework\TestCase;
+
+class RouterTest extends TestCase
+{
+    public Mage_Core_Controller_Front_Router $subject;
+
+    public function setUp(): void
+    {
+        Mage::app();
+        $config = new Mage_Core_Model_Config_Element('<?xml version="1.0" encoding="utf-8" ?><test-url />');
+        $this->subject = new Mage_Core_Controller_Front_Router($config);
+    }
+
+    /**
+     * @group Mage_Core
+     * @group Mage_Core_Controller
+     */
+    public function testGetUrl(): void
+    {
+        $this->assertStringEndsWith('test-url/', $this->subject->getUrl());
+    }
+}