Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Mage_Core_Controller_Front_Router::getUrl() #4356

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sreichel
Copy link
Contributor

Description (*)

Fatal error: Uncaught Exception: Notice: Array to string conversion in /var/www/html/app/code/core/Mage/Core/Model/Store.php on line 580

Manual testing scenarios (*)

$config = new Mage_Core_Model_Config_Element('<?xml version="1.0" encoding="utf-8" ?><test-url />');
$router = new Mage_Core_Controller_Front_Router($config);
var_dump($router->getUrl());

@github-actions github-actions bot added Component: Core Relates to Mage_Core Mage.php Relates to app/Mage.php labels Nov 15, 2024
app/Mage.php Show resolved Hide resolved
@kiatng
Copy link
Contributor

kiatng commented Nov 18, 2024

Any idea where is this class Mage_Core_Controller_Front_Router reference in the core? I didn't find any, should it be marked @deprecated?

@sreichel
Copy link
Contributor Author

Seems not to be used. I thought abiut to mark it deprecated, but there is no replacement that offers same functionallity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Relates to Mage_Core Mage.php Relates to app/Mage.php phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants