[Backend]Test player creation/update

openbas-api/src/test/java/io/openbas/rest/PlayerApiTest.java

@@ -0,0 +1,275 @@
+package io.openbas.rest;
+
+import static io.openbas.config.AppConfig.EMAIL_FORMAT;
+import static io.openbas.rest.user.PlayerApi.PLAYER_URI;
+import static io.openbas.utils.JsonUtils.asJsonString;
+import static io.openbas.utils.fixtures.PlayerFixture.PLAYER_FIXTURE_FIRSTNAME;
+import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.TestInstance.Lifecycle.PER_CLASS;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+
+import com.jayway.jsonpath.JsonPath;
+import io.openbas.IntegrationTest;
+import io.openbas.database.model.Organization;
+import io.openbas.database.model.Tag;
+import io.openbas.database.model.User;
+import io.openbas.database.repository.OrganizationRepository;
+import io.openbas.database.repository.TagRepository;
+import io.openbas.database.repository.UserRepository;
+import io.openbas.rest.user.form.player.PlayerInput;
+import io.openbas.utils.fixtures.OrganizationFixture;
+import io.openbas.utils.fixtures.PlayerFixture;
+import io.openbas.utils.fixtures.TagFixture;
+import io.openbas.utils.mockUser.WithMockAdminUser;
+import io.openbas.utils.mockUser.WithMockPlannerUser;
+import jakarta.servlet.ServletException;
+import java.util.List;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestInstance;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.http.MediaType;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.transaction.annotation.Transactional;
+
+@TestInstance(PER_CLASS)
+@Transactional
+class PlayerApiTest extends IntegrationTest {
+
+  @Autowired private MockMvc mvc;
+
+  @Value("${openbas.admin.email:#{null}}")
+  private String adminEmail;
+
+  @Autowired private OrganizationRepository organizationRepository;
+  @Autowired private TagRepository tagRepository;
+  @Autowired private UserRepository userRepository;
+
+  @DisplayName("Given valid player input, should create a player successfully")
+  @Test
+  @WithMockAdminUser
+  void given_validPlayerInput_should_createPlayerSuccessfully() throws Exception {
+    // -- PREPARE --
+    PlayerInput playerInput = buildPlayerInput();
+
+    // -- EXECUTE --
+    String response =
+        mvc.perform(
+                post(PLAYER_URI)
+                    .content(asJsonString(playerInput))
+                    .contentType(MediaType.APPLICATION_JSON)
+                    .accept(MediaType.APPLICATION_JSON))
+            .andExpect(status().is2xxSuccessful())
+            .andReturn()
+            .getResponse()
+            .getContentAsString();
+
+    // -- ASSERT --
+    assertEquals(PLAYER_FIXTURE_FIRSTNAME, JsonPath.read(response, "$.user_firstname"));
+    assertEquals(playerInput.getTagIds().getFirst(), JsonPath.read(response, "$.user_tags[0]"));
+    assertEquals(playerInput.getOrganizationId(), JsonPath.read(response, "$.user_organization"));
+  }
+
+  @DisplayName("Given invalid email in player input, should throw exceptions")
+  @Test
+  @WithMockAdminUser
+  void given_invalidEmailInPlayerInput_should_throwExceptions() throws Exception {
+    // -- PREPARE --
+    PlayerInput playerInput = new PlayerInput();
+    playerInput.setEmail("email");
+
+    // -- EXECUTE --
+    String response =
+        mvc.perform(
+                post(PLAYER_URI)
+                    .content(asJsonString(playerInput))
+                    .contentType(MediaType.APPLICATION_JSON)
+                    .accept(MediaType.APPLICATION_JSON))
+            .andExpect(status().is4xxClientError())
+            .andReturn()
+            .getResponse()
+            .getContentAsString();
+
+    // -- ASSERT --
+    assertTrue(response.contains(EMAIL_FORMAT));
+  }
+
+  @DisplayName("Given restricted user, should not allow creation of player")
+  @Test
+  @WithMockPlannerUser
+  void given_restrictedUser_should_notAllowPlayerCreation() {
+    // -- PREPARE --
+    PlayerInput playerInput = buildPlayerInput();
+
+    // --EXECUTE--
+    Exception exception =
+        assertThrows(
+            ServletException.class,
+            () ->
+                mvc.perform(
+                    post(PLAYER_URI)
+                        .content(asJsonString(playerInput))
+                        .contentType(MediaType.APPLICATION_JSON)
+                        .accept(MediaType.APPLICATION_JSON)));
+
+    // --ASSERT--
+    assertTrue(exception.getMessage().contains("User is restricted"));
+  }
+
+  @DisplayName("Given valid player input, should upsert player successfully")
+  @Test
+  @WithMockAdminUser
+  void given_validPlayerInput_should_upsertPlayerSuccessfully() throws Exception {
+    // --PREPARE--
+    PlayerInput playerInput = buildPlayerInput();
+    User user = new User();
+    user.setUpdateAttributes(playerInput);
+    userRepository.save(user);
+    String newFirstname = "updatedFirstname";
+    playerInput.setFirstname(newFirstname);
+
+    // -- EXECUTE --
+    String response =
+        mvc.perform(
+                post(PLAYER_URI + "/upsert")
+                    .content(asJsonString(playerInput))
+                    .contentType(MediaType.APPLICATION_JSON)
+                    .accept(MediaType.APPLICATION_JSON))
+            .andExpect(status().is2xxSuccessful())
+            .andReturn()
+            .getResponse()
+            .getContentAsString();
+
+    // -- ASSERT --
+    assertEquals(newFirstname, JsonPath.read(response, "$.user_firstname"));
+  }
+
+  @DisplayName("Given non-existing player input, should upsert successfully")
+  @Test
+  @WithMockAdminUser
+  void given_nonExistingPlayerInput_should_upsertSuccessfully() throws Exception {
+    // --PREPARE--
+    PlayerInput playerInput = buildPlayerInput();
+
+    // --EXECUTE--
+    String response =
+        mvc.perform(
+                post(PLAYER_URI + "/upsert")
+                    .content(asJsonString(playerInput))
+                    .contentType(MediaType.APPLICATION_JSON)
+                    .accept(MediaType.APPLICATION_JSON))
+            .andExpect(status().is2xxSuccessful())
+            .andReturn()
+            .getResponse()
+            .getContentAsString();
+
+    // --ASSERT--
+    assertEquals(PLAYER_FIXTURE_FIRSTNAME, JsonPath.read(response, "$.user_firstname"));
+  }
+
+  @DisplayName("Given valid player ID and input, should update player successfully")
+  @Test
+  @WithMockAdminUser
+  void given_validPlayerIdAndInput_should_updatePlayerSuccessfully() throws Exception {
+    // -- PREPARE --
+    PlayerInput playerInput = buildPlayerInput();
+    User user = new User();
+    user.setUpdateAttributes(playerInput);
+    userRepository.save(user);
+    String newFirstname = "updatedFirstname";
+    playerInput.setFirstname(newFirstname);
+
+    // --EXECUTE--
+    String response =
+        mvc.perform(
+                put(PLAYER_URI + "/" + user.getId())
+                    .content(asJsonString(playerInput))
+                    .contentType(MediaType.APPLICATION_JSON)
+                    .accept(MediaType.APPLICATION_JSON))
+            .andExpect(status().is2xxSuccessful())
+            .andReturn()
+            .getResponse()
+            .getContentAsString();
+
+    // --ASSERT--
+    assertEquals("updatedFirstname", JsonPath.read(response, "$.user_firstname"));
+  }
+
+  @DisplayName("Given restricted user, should not allow updating a player")
+  @Test
+  @WithMockPlannerUser
+  void given_restrictedUser_should_notAllowPlayerUpdate() {
+    // -- PREPARE --
+    PlayerInput playerInput = buildPlayerInput();
+    User user = userRepository.findByEmailIgnoreCase(adminEmail).orElseThrow();
+
+    // -- EXECUTE --
+    Exception exception =
+        assertThrows(
+            ServletException.class,
+            () ->
+                mvc.perform(
+                    put(PLAYER_URI + "/" + user.getId())
+                        .content(asJsonString(playerInput))
+                        .contentType(MediaType.APPLICATION_JSON)
+                        .accept(MediaType.APPLICATION_JSON)));
+
+    // --ASSERT--
+    assertTrue(exception.getMessage().contains("You dont have the right to update this user"));
+  }
+
+  @DisplayName("Given valid player ID, should delete player successfully")
+  @Test
+  @WithMockAdminUser
+  void given_validPlayerId_should_deletePlayerSuccessfully() throws Exception {
+    // -- PREPARE --
+    PlayerInput playerInput = buildPlayerInput();
+    User user = new User();
+    user.setUpdateAttributes(playerInput);
+    user = userRepository.save(user);
+
+    // -- EXECUTE --
+    mvc.perform(
+            delete(PLAYER_URI + "/" + user.getId())
+                .contentType(MediaType.APPLICATION_JSON)
+                .accept(MediaType.APPLICATION_JSON))
+        .andExpect(status().is2xxSuccessful())
+        .andReturn()
+        .getResponse()
+        .getContentAsString();
+
+    // -- ASSERT --
+    assertTrue(this.userRepository.findById(user.getId()).isEmpty());
+  }
+
+  @DisplayName("Given no existing player ID, should throw an exception")
+  @Test
+  @WithMockAdminUser
+  void given_notExistingAssetGroup_should_throwAnException() {
+    // -- PREPARE --
+    String nonexistentAssetGroupId = "nonexistent-id";
+
+    // --EXECUTE--
+    assertThrows(
+        ServletException.class,
+        () ->
+            mvc.perform(
+                delete(PLAYER_URI + "/" + nonexistentAssetGroupId)
+                    .contentType(MediaType.APPLICATION_JSON)
+                    .accept(MediaType.APPLICATION_JSON)));
+  }
+
+  // -- PRIVATE --
+
+  private PlayerInput buildPlayerInput() {
+    Organization organization =
+        organizationRepository.save(OrganizationFixture.createOrganization());
+    Tag tag = tagRepository.save(TagFixture.getTag());
+    PlayerInput player = PlayerFixture.createPlayerInput();
+    player.setOrganizationId(organization.getId());
+    player.setTagIds(List.of(tag.getId()));
+    return player;
+  }
+}

openbas-api/src/test/java/io/openbas/utils/fixtures/OrganizationFixture.java

@@ -0,0 +1,15 @@
+package io.openbas.utils.fixtures;
+
+import io.openbas.database.model.Organization;
+
+public class OrganizationFixture {
+
+  public static final String ORGANIZATION_FIXTURE_NAME = "Filigran test";
+
+  public static Organization createOrganization() {
+    Organization organization = new Organization();
+    organization.setName(ORGANIZATION_FIXTURE_NAME);
+    organization.setDescription("Filigran test organization");
+    return organization;
+  }
+}

openbas-api/src/test/java/io/openbas/utils/fixtures/PlayerFixture.java

@@ -0,0 +1,20 @@
+package io.openbas.utils.fixtures;
+
+import io.openbas.rest.user.form.player.PlayerInput;
+
+public class PlayerFixture {
+
+  public static final String PLAYER_FIXTURE_FIRSTNAME = "Firstname";
+  public static final String PLAYER_FIXTURE_MAIL = "[email protected]";
+
+  public static PlayerInput createPlayerInput() {
+    PlayerInput player = new PlayerInput();
+    player.setEmail(PLAYER_FIXTURE_MAIL);
+    player.setFirstname(PLAYER_FIXTURE_FIRSTNAME);
+    player.setLastname("Lastname");
+    player.setCountry("France");
+    player.setPhone("+33123456789");
+    player.setPgpKey("a123b");
+    return player;
+  }
+}