Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend]Test player creation/update #2139

Open
wants to merge 7 commits into
base: release/1.11.0
Choose a base branch
from

Conversation

johanah29
Copy link
Member

@johanah29 johanah29 self-assigned this Dec 31, 2024
@johanah29 johanah29 linked an issue Dec 31, 2024 that may be closed by this pull request
@RomuDeuxfois
Copy link
Member

Can you take care of upsertPlayer as well ? thx

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.47%. Comparing base (552196f) to head (b46f0a0).
Report is 3 commits behind head on release/1.11.0.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/1.11.0    #2139      +/-   ##
====================================================
+ Coverage             35.98%   36.47%   +0.48%     
- Complexity             1487     1501      +14     
====================================================
  Files                   546      546              
  Lines                 16626    16626              
  Branches               1061     1061              
====================================================
+ Hits                   5983     6064      +81     
+ Misses                10340    10253      -87     
- Partials                303      309       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@antoinemzs antoinemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good coverage, however we seem to not validate bevhaviour on invalid inputs (e.g. HTTP 400). Could do with a small test case? Or is it validated as a blanket error somewhere else? (i.e. as a generic deserialisation error code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Unit testing - people scope ] - players creation/update
3 participants