-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend]Test player creation/update #2139
base: release/1.11.0
Are you sure you want to change the base?
Conversation
ba3d07d
to
eab8693
Compare
Can you take care of upsertPlayer as well ? thx |
3f0554c
to
55b74f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.11.0 #2139 +/- ##
====================================================
+ Coverage 35.98% 36.47% +0.48%
- Complexity 1487 1501 +14
====================================================
Files 546 546
Lines 16626 16626
Branches 1061 1061
====================================================
+ Hits 5983 6064 +81
+ Misses 10340 10253 -87
- Partials 303 309 +6 ☔ View full report in Codecov by Sentry. |
78143cc
to
52a9440
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good coverage, however we seem to not validate bevhaviour on invalid inputs (e.g. HTTP 400). Could do with a small test case? Or is it validated as a blanket error somewhere else? (i.e. as a generic deserialisation error code)
#1490