Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Probe
I initially created the PR the fix the below bug but then I realised that there was something going on with this.
I discovered that ports are not supported by
node-ping
(see here) so I removed the ports test cases and also took advantage to refactor a bit the codePingMonitor.ts
code as well as the tests.NOTE: one could add support to ports probably by using other library or using
sockets
(and thenet
) but didn't add it here because it was a bit out of the scope.Initial bug:
Pull Request Checklist:
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if such).Related Issue?
Screenshots (if appropriate):