chore: add BillingService.ts test coverage #881
Conversation
fedealconada
force-pushed
the
billing-service-coverage
branch
2 times, most recently
from
b2e3734
to
0c265bd
Compare
fedealconada
force-pushed
the
billing-service-coverage
branch
from
91b0cca
to
d3bb9f2
Compare
|
This is ready for review @simlarsen, the build fails on the Probe service but probably #884 fixes that |
CommonServer/Utils/Errors.ts
Outdated
| SUBSCRIPTION_NOT_FOUND: 'Subscription not found.', | ||
| NO_PAYMENTS_METHODS: | ||
| 'No payment methods added. Please add your card to this project to change your plan', | ||
| /// @dev consider consolidating the above and below error messages |
There was a problem hiding this comment.
Please consoliate this to: Payment Method not added. Please go to Project Settings > Billing and add a payment method.
| @@ -0,0 +1,16 @@ | |||
| import * as mock from 'jest-mock-extended'; | |||
| trialDate = OneUptimeDate.getSomeDaysAfter( | ||
| data.plan.getTrialPeriod() | ||
| ); | ||
| trialDate = data.trial |
There was a problem hiding this comment.
use this condition in if else above
Common/Utils/Errors.ts
Outdated
| @@ -0,0 +1,7 @@ | |||
| export default { | |||
| API: { | |||
| CLIENT_SECRET_MISSING: | |||
There was a problem hiding this comment.
Why not move this to Errors file in CommonServer under BillingService?
There was a problem hiding this comment.
Since this is an APIException, I felt like it was better to put it in Common/Utils, but happy to move that one as well as INVOICE_NOT_GENERATED to CommonServer/Utils/Errors.ts file.
What do you prefer?
There was a problem hiding this comment.
Lets move it to CommonServer since they are related to Billing and are only used in CommonServer
fedealconada
force-pushed
the
billing-service-coverage
branch
from
4df7acc
to
250653a
Compare
fedealconada
force-pushed
the
billing-service-coverage
branch
from
250653a
to
a52b2be
Compare
BillingService coverage
BillingService.ts(95%)__mocks__directory that would contain external libraries mocks (e.g Stripe)BillingService.tsstring errors to a separate Errors.ts filecollectCoverage: falseon jest config to improve test speedPull Request Checklist:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).Related Issue?
Screenshots (if appropriate):