-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui(components): Adds ToolButton and ToolButtonList to ui-next #4670
Open
dan-rukas
wants to merge
9
commits into
OHIF:master
Choose a base branch
from
dan-rukas:feat/tool-components
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool activates now with existing toolbar logic
Tooltip works and will use 'tooltip' if available, if not it will use 'label' defined in toolbarButtons.ts
removed ohif.radioGroup with new ohif.toolButton
Replaces previous splitButton component in the toolbar.
Styles are no longer duplicated in two places
Only includes ToolButton currently
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dan-rukas
changed the title
ui(components): Adds ToolButton and ToolButtonList core components to ui-next
ui(components): Adds ToolButton and ToolButtonList to ui-next
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Introduces two new original core components:
ToolButton
andToolButtonList
in theui-next
library to provide both "single tool" and “split button” functionality for the OHIF Toolbar. This PR also updates the existing toolbar configuration to demonstrate usage of both components and integrates seamlessly with theToolbarService
logic. Several files have been modified or created to support these changes, and newui-next
components (such asTooltip
,Button
,DropdownMenu
) are leveraged.Changes & Results
ToolButton.tsx
(New ui-next component)Tooltip
,Button
,Icons
ToolButtonList.tsx
(New ui-next component)ToolButton
for the primary tool display andDropdownMenu
for secondary tools.TooltipProvider
,Button
,Icons
, andDropdownMenu
from ui-nextToolButtonList
component that supports a “primary” tool and a list of additional “secondary tools.”getToolbarModule.tsx
ohif.toolButton
andohif.toolButtonList
to map UI Type to the newly createdToolButtonList
component.ToolbarService
can renderToolButtonList
whenuiType: 'ohif.toolButtonList'
is encountered.toolbarButtons.ts
MeasurementTools
button fromohif.splitButton
toohif.toolButtonList
.primary
anditems
structure but now points to the new UI type.evaluate.group.promoteToPrimaryIfCornerstoneToolNotActiveInTheList
) for tool promotion.components-list.tsx
(Docs)ToolButton
.Testing
New Toolbar components are currently working in
Basic Viewer
mode (tested in Chrome)Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment