-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui(components): New tool components ToolToggle and ToolToggleList (WIP) #4653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toggle no longer toggles for ToolToggle since a tools remains active even when clicked again
Border radius size fixed
Tooltip shows only if label is defined
New component uses Toggle and ToggleTool as a base then adds the DropdownMenu component to list secondary tools. Selected tools will switch in the toolbar.
…kas/Viewers into feat/component-toolbutton
dan-rukas
changed the title
ui(component) Tool components ToolToggle and ToolToggleList (WIP)
ui(component): Tool components ToolToggle and ToolToggleList (WIP)
Jan 7, 2025
✅ Deploy Preview for ohif-dev canceled.
|
❌ Deploy Preview for ohif-platform-docs failed. Why did it fail? →
|
dan-rukas
changed the title
ui(component): Tool components ToolToggle and ToolToggleList (WIP)
ui(components): Tool components ToolToggle and ToolToggleList (WIP)
Jan 7, 2025
dan-rukas
changed the title
ui(components): Tool components ToolToggle and ToolToggleList (WIP)
ui(components): New tool components ToolToggle and ToolToggleList (WIP)
Jan 7, 2025
This PR has been replaced by #4670 Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
WIP: Added new components ToolToggle and ToolToggleList
This PR introduces three new components (
Toggle
,ToolToggle
, andToolToggleList
) using shad/cn and@radix-ui/react-toggle
.Please note this is DRAFT and does not include all functionality or final design. This PR in NOT COMPLETE.
Changes & Results
Toggle
@radix-ui/react-toggle
that uses ourclass-variance-authority
(cva
) styling.variant="tool"
,size="default"
, etc.) to match our design system.ToolToggle
Toggle
for single-tool usage.pressed === false
attempts.Tooltip
to show the tool’s label on hover.ToolToggleList
(Design in progress)ToolToggle
for the primary tool.DropdownMenu
listing secondary tools.onInteraction
so the parent can handle the newly selected tool.Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment