DefaultDebugDrawer: transform bones and set axes size #2843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this for my project. It seems to work and thought it might be useful for others. However…
The docs say that Node::_getFullTransform() “should only be called by a SceneManager which knows the derived transforms have been updated before calling this method.” I do not know if that is the case when Entity::_updateRenderQueue() is called. Please advise.
The DefaultDebugDrawer::drawAxes() size parameter could come from DefaultDebugDrawer or from Entity. Rather than add a debug data member to every Entity I thought it better to have it in just the DefaultDebugDrawer. However that means to set the value, we either have to change SceneManager’s interface, or just cast the return of SceneManager::getDebugDrawer() to a DefaultDebugDrawer *, which is what I’m doing.
Not sure about my design decisions. Open to feedback.