Skip to content

More code cleanup

Sign in for the full log view
GitHub Actions / Qodana Community for .NET failed Feb 21, 2024 in 0s

115 new problems found by Qodana Community for .NET

Qodana Community for .NET

115 new problems were found

Inspection name Severity Problems
Missing XML comment for publicly visible type or member 🔶 Warning 9
Auto-property accessor is never used: Non-private accessibility 🔶 Warning 7
Inconsistent Naming 🔶 Warning 7
XML comment has a 'param' tag for 'Parameter', but there is no parameter by that name 🔶 Warning 4
Parameter has no matching param tag in the XML comment 🔶 Warning 3
Unused parameter: Private accessibility 🔶 Warning 1
Class is never instantiated: Non-private accessibility ◽️ Notice 22
Type member is never used: Non-private accessibility ◽️ Notice 20
Member can be made private: Non-private accessibility ◽️ Notice 17
Type member is never accessed via base type: Non-private accessibility ◽️ Notice 9
Auto-property can be made get-only: Non-private accessibility ◽️ Notice 4
Unused parameter: Non-private accessibility ◽️ Notice 3
Method return value is never used: Non-private accessibility ◽️ Notice 3
Property can be made init-only: Non-private accessibility ◽️ Notice 2
Struct can be made readonly ◽️ Notice 2
Type is never used: Non-private accessibility ◽️ Notice 1
Non-accessed field: Non-private accessibility ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check notice on line 26 in benchmarks/NexusMods.EventSourcing.Benchmarks/Benchmarks/ReadTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Member can be made private: Non-private accessibility 

Constant 'MaxCount' can be made private

Check notice on line 67 in benchmarks/NexusMods.EventSourcing.Benchmarks/Benchmarks/ReadTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Member can be made private: Non-private accessibility 

Property 'Order' can be made private

Check notice on line 69 in benchmarks/NexusMods.EventSourcing.Benchmarks/Benchmarks/ReadTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Member can be made private: Non-private accessibility 

Property 'Ids' can be made private

Check notice on line 67 in benchmarks/NexusMods.EventSourcing.Benchmarks/Benchmarks/ReadTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Auto-property can be made get-only: Non-private accessibility 

Auto-property can be made get-only

Check notice on line 56 in benchmarks/NexusMods.EventSourcing.Benchmarks/Benchmarks/ReadTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Property can be made init-only: Non-private accessibility 

Property can be made init-only

Check notice on line 24 in benchmarks/NexusMods.EventSourcing.Benchmarks/Benchmarks/WriteTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Member can be made private: Non-private accessibility 

Property 'Count' can be made private

Check notice on line 24 in benchmarks/NexusMods.EventSourcing.Benchmarks/Benchmarks/WriteTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Auto-property can be made get-only: Non-private accessibility 

Auto-property can be made get-only

Check notice on line 23 in src/NexusMods.EventSourcing.Abstractions/Datom.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never used: Non-private accessibility 

Property 'ValueType' is never used

Check notice on line 13 in src/NexusMods.EventSourcing.Abstractions/Datom.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never accessed via base type: Non-private accessibility 

Only implementations of property 'Entity' are used

Check notice on line 18 in src/NexusMods.EventSourcing.Abstractions/Datom.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never accessed via base type: Non-private accessibility 

Only implementations of property 'Attribute' are used

Check notice on line 48 in src/NexusMods.EventSourcing.Abstractions/Datom.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never accessed via base type: Non-private accessibility 

Only implementations of property 'Tx' are used

Check notice on line 24 in src/NexusMods.EventSourcing.Abstractions/IAttribute.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never used: Non-private accessibility 

Property 'IsMultiCardinality' is never used

Check notice on line 29 in src/NexusMods.EventSourcing.Abstractions/IAttribute.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never used: Non-private accessibility 

Property 'IsReference' is never used

Check notice on line 60 in src/NexusMods.EventSourcing.Abstractions/IAttribute.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never accessed via base type: Non-private accessibility 

Only implementations of method 'Add' are used

Check notice on line 19 in src/NexusMods.EventSourcing.Abstractions/IConnection.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never accessed via base type: Non-private accessibility 

Only implementations of property 'TxId' are used

Check notice on line 26 in src/NexusMods.EventSourcing.Abstractions/IConnection.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never accessed via base type: Non-private accessibility 

Only implementations of method 'Transact' are used

Check notice on line 37 in src/NexusMods.EventSourcing.Abstractions/IConnection.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never accessed via base type: Non-private accessibility 

Only implementations of property 'Commits' are used

Check warning on line 13 in src/NexusMods.EventSourcing.Abstractions/IDatomStore.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Missing XML comment for publicly visible type or member 

Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.IDatomStore.Transact'

Check notice on line 36 in src/NexusMods.EventSourcing.Abstractions/IDb.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Unused parameter: Non-private accessibility 

Parameter 'id' is not used in any of the implementations

Check notice on line 36 in src/NexusMods.EventSourcing.Abstractions/Ids.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Member can be made private: Non-private accessibility 

Method 'MakeId' can be made private

Check notice on line 66 in src/NexusMods.EventSourcing.Abstractions/Ids.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Member can be made private: Non-private accessibility 

Method 'GetPartition' can be made private

Check warning on line 5 in src/NexusMods.EventSourcing.Abstractions/Ids.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Missing XML comment for publicly visible type or member 

Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.Ids.Partition'

Check warning on line 3 in src/NexusMods.EventSourcing.Abstractions/Ids.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Missing XML comment for publicly visible type or member 

Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.Ids'

Check notice on line 34 in src/NexusMods.EventSourcing.Abstractions/IEntityIterator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never used: Non-private accessibility 

Method 'GetValue' is never used

Check notice on line 40 in src/NexusMods.EventSourcing.Abstractions/IEntityIterator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for .NET

Type member is never used: Non-private accessibility 

Property 'AttributeId' is never used
View more details on GitHub Actions