Skip to content

More code cleanup

More code cleanup #11

Triggered via push February 21, 2024 04:25
Status Failure
Total duration 1m 56s
Artifacts

code_quality.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

1 error, 32 warnings, and 84 notices
qodana
The number of problems exceeds the failThreshold
Missing XML comment for publicly visible type or member: src/NexusMods.EventSourcing.Abstractions/IDatomStore.cs#L13
Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.IDatomStore.Transact'
Missing XML comment for publicly visible type or member: src/NexusMods.EventSourcing.Abstractions/Ids.cs#L5
Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.Ids.Partition'
Missing XML comment for publicly visible type or member: src/NexusMods.EventSourcing.Abstractions/Ids.cs#L3
Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.Ids'
Missing XML comment for publicly visible type or member: src/NexusMods.EventSourcing.Abstractions/ITransaction.cs#L5
Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.ITransaction'
Parameter has no matching param tag in the XML comment: src/NexusMods.EventSourcing.Abstractions/Models/AReadModel.cs#L31
Parameter 'entityId' has no matching param tag in the XML comment for NexusMods.EventSourcing.Abstractions.Models.AReadModel<TOuter>.Get<TReadModel> (but other parameters do)
Parameter has no matching param tag in the XML comment: src/NexusMods.EventSourcing.Abstractions/ScalarAttribute.cs#L19
Parameter 'uniqueName' has no matching param tag in the XML comment for NexusMods.EventSourcing.Abstractions.ScalarAttribute<TAttribute,TValueType>.ScalarAttribute (but other parameters do)
Parameter has no matching param tag in the XML comment: src/NexusMods.EventSourcing.Abstractions/ScalarAttribute.cs#L30
Parameter 'symbol' has no matching param tag in the XML comment for NexusMods.EventSourcing.Abstractions.ScalarAttribute<TAttribute,TValueType>.ScalarAttribute (but other parameters do)
Missing XML comment for publicly visible type or member: src/NexusMods.EventSourcing.Abstractions/ScalarAttribute.cs#L35
Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.ScalarAttribute<TAttribute,TValueType>.Read'
Missing XML comment for publicly visible type or member: src/NexusMods.EventSourcing.Abstractions/ScalarAttribute.cs#L48
Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.ScalarAttribute<TAttribute,TValueType>.SetSerializer'
Missing XML comment for publicly visible type or member: src/NexusMods.EventSourcing.Abstractions/ScalarAttribute.cs#L68
Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.ScalarAttribute<TAttribute,TValueType>.Read'
Missing XML comment for publicly visible type or member: src/NexusMods.EventSourcing.Abstractions/ScalarAttribute.cs#L76
Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.ScalarAttribute<TAttribute,TValueType>.Assert'
Missing XML comment for publicly visible type or member: src/NexusMods.EventSourcing.Abstractions/TxId.cs#L6
Missing XML comment for publicly visible type or member 'NexusMods.EventSourcing.Abstractions.TxId'
Inconsistent Naming: src/NexusMods.EventSourcing.DatomStore/Indexes/AETVIndex.cs#L9
Name 'AETVIndex' does not match rule 'Types and namespaces'. Suggested name is 'AetvIndex'.
Inconsistent Naming: src/NexusMods.EventSourcing.DatomStore/Indexes/AETVIndex.cs#L26
Name 'AEVTByAIterator' does not match rule 'Types and namespaces'. Suggested name is 'AevtByAIterator'.
Inconsistent Naming: src/NexusMods.EventSourcing.DatomStore/Indexes/AVTEIndex.cs#L10
Name 'AVTEIndex' does not match rule 'Types and namespaces'. Suggested name is 'AvteIndex'.
Inconsistent Naming: src/NexusMods.EventSourcing.DatomStore/Indexes/AVTEIndex.cs#L27
Name 'AVTEIterator' does not match rule 'Types and namespaces'. Suggested name is 'AvteIterator'.
Inconsistent Naming: src/NexusMods.EventSourcing.DatomStore/Indexes/EATVIndex.cs#L11
Name 'EATVIndex' does not match rule 'Types and namespaces'. Suggested name is 'EatvIndex'.
Inconsistent Naming: src/NexusMods.EventSourcing.DatomStore/Indexes/EATVIndex.cs#L58
Name 'EATVIterator' does not match rule 'Types and namespaces'. Suggested name is 'EatvIterator'.
Inconsistent Naming: tests/NexusMods.EventSourcing.Tests/DbTests.cs#L52
Name 'TIMES' does not match rule 'Local constants'. Suggested name is 'times'.
qodana
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, JetBrains/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Unused parameter: Non-private accessibility: src/NexusMods.EventSourcing.Abstractions/IDb.cs#L36
Parameter 'id' is not used in any of the implementations
Unused parameter: Non-private accessibility: src/NexusMods.EventSourcing.Abstractions/ITransaction.cs#L35
Parameter 'isAssert' is not used in any of the implementations
Non-accessed field: Non-private accessibility: tests/NexusMods.EventSourcing.DatomStore.Tests/ADatomStoreTest.cs#L12
Field 'Connection' is assigned but its value is never used