Code cleanup

qodana.yaml

@@ -5,3 +5,5 @@ dotnet:
   solution: NexusMods.EventSourcing.sln
 profile:
   name: qodana.recommended
+exclude:
+  - name: ClassNeverInstantiated.Global

src/NexusMods.EventSourcing.Abstractions/Symbol.cs

@@ -21,7 +21,7 @@ private Symbol(string nsAndName)
         Namespace = nsAndName[..splitOn];
     }
 
-    private static ConcurrentDictionary<string, Symbol> _internedSymbols = new();
+    private static readonly ConcurrentDictionary<string, Symbol> _internedSymbols = new();
 
     /// <summary>
     /// Construct a new symbol, or return an existing one that matches the given name

src/NexusMods.EventSourcing.DatomStore/BuiltInAttributes.cs

@@ -15,12 +15,12 @@ public class UniqueId() : ScalarAttribute<UniqueId, Symbol>(UniqueIdStaticId);
     /// <summary>
     /// Static unique id of the UniqueId attribute
     /// </summary>
-    public static Symbol UniqueIdStaticId = Symbol.Intern("NexusMods.EventSourcing.DatomStore/UniqueId");
+    public static readonly Symbol UniqueIdStaticId = Symbol.Intern("NexusMods.EventSourcing.DatomStore/UniqueId");
 
     /// <summary>
     /// The database entity id of the UniqueId attribute
     /// </summary>
-    public static ulong UniqueIdEntityId = 1;
+    public static readonly ulong UniqueIdEntityId = 1;
 
     /// <summary>
     /// The unique id if the IValueSerializer used to serialize the value of the attribute.
@@ -30,23 +30,23 @@ public class ValueSerializerId() : ScalarAttribute<ValueSerializerId, UInt128>("
     /// <summary>
     /// Static unique id of the UniqueId attribute
     /// </summary>
-    public static Symbol ValueSerializerIdStaticId = Symbol.Intern("NexusMods.EventSourcing.DatomStore/ValueSerializerId");
+    public static readonly Symbol ValueSerializerIdStaticId = Symbol.Intern("NexusMods.EventSourcing.DatomStore/ValueSerializerId");
 
     /// <summary>
     /// The database entity id of the UniqueId attribute
     /// </summary>
-    public static ulong ValueSerializerIdEntityId = 2;
+    public static readonly ulong ValueSerializerIdEntityId = 2;
 
 
     /// <summary>
     /// The initial set of built-in attributes that always exist in the database.
     /// </summary>
-    public static DbAttribute[] Initial = [
+    public static readonly DbAttribute[] Initial = [
         new DbAttribute(UniqueIdStaticId, UniqueIdEntityId, UInt128Serializer.Id),
         new DbAttribute(ValueSerializerIdStaticId, ValueSerializerIdEntityId, UInt128Serializer.Id),
     ];
 
-    public static IDatom[] InitialDatoms = [
+    public static readonly IDatom[] InitialDatoms = [
         UniqueId.Assert(UniqueIdEntityId, UniqueIdStaticId),
         ValueSerializerId.Assert(UniqueIdEntityId, UInt128Serializer.Id),
 

src/NexusMods.EventSourcing.DatomStore/RocksDBDatomStore.cs

@@ -12,7 +12,7 @@ namespace NexusMods.EventSourcing.DatomStore;
 
 public class RocksDBDatomStore : IDatomStore
 {
-    private object _lock = new();
+    private readonly object _lock = new();
     private readonly ILogger<RocksDBDatomStore> _logger;
     private readonly DatomStoreSettings _settings;
     private readonly DbOptions _options;

src/NexusMods.EventSourcing/Transaction.cs

@@ -8,8 +8,8 @@ namespace NexusMods.EventSourcing;
 public class Transaction(Connection connection) : ITransaction
 {
     private ulong _tempId = Ids.MinId(Ids.Partition.Tmp) + 1;
-    private ConcurrentBag<IDatom> _datoms = new();
-    private ConcurrentBag<IReadModel> _models = new();
+    private readonly ConcurrentBag<IDatom> _datoms = new();
+    private readonly ConcurrentBag<IReadModel> _models = new();
 
     /// <inhertdoc />
     public EntityId TempId()

tests/NexusMods.EventSourcing.DatomStore.Tests/DatomStoreSetupTests.cs

@@ -2,13 +2,9 @@
 
 namespace NexusMods.EventSourcing.DatomStore.Tests;
 
-public class DatomStoreSetupTests : ADatomStoreTest
+public class DatomStoreSetupTests(IEnumerable<IValueSerializer> valueSerializers, IEnumerable<IAttribute> attributes)
+    : ADatomStoreTest(valueSerializers, attributes)
 {
-    public DatomStoreSetupTests(IEnumerable<IValueSerializer> valueSerializers, IEnumerable<IAttribute> attributes)
-        : base(valueSerializers, attributes)
-    {
-    }
-
     [Fact]
     public void CanGetAttributesFromDatomStore()
     {

tests/NexusMods.EventSourcing.Tests/DbTests.cs

@@ -5,15 +5,9 @@
 
 namespace NexusMods.EventSourcing.Tests;
 
-public class DbTests : AEventSourcingTest
+public class DbTests(IEnumerable<IValueSerializer> valueSerializers, IEnumerable<IAttribute> attributes)
+    : AEventSourcingTest(valueSerializers, attributes)
 {
-
-    public DbTests(IEnumerable<IValueSerializer> valueSerializers, IEnumerable<IAttribute> attributes)
-        : base(valueSerializers, attributes)
-    {
-
-    }
-
     [Fact]
     public void ReadDatomsForEntity()
     {