Fix the tests

benchmarks/NexusMods.EventSourcing.Benchmarks/Program.cs

@@ -2,14 +2,15 @@
 
 using System;
 using System.Diagnostics;
-using BenchmarkDotNet.Running;
 using NexusMods.EventSourcing.Benchmarks.Benchmarks;
 
 
 #if DEBUG
 
-var benchmark = new ReadTests();
-benchmark.Count = 1000;
+var benchmark = new ReadTests
+{
+    Count = 1000
+};
 
 var sw = Stopwatch.StartNew();
 benchmark.Setup();

src/NexusMods.EventSourcing.Abstractions/Datom.cs

@@ -4,9 +4,26 @@ namespace NexusMods.EventSourcing.Abstractions;
 
 public interface IDatom
 {
-    ulong E { get; }
+    /// <summary>
+    /// The entity id of the datom
+    /// </summary>
+    ulong Entity { get; }
+
+    /// <summary>
+    /// The attribute of the datom
+    /// </summary>
     Type Attribute { get; }
+
+    /// <summary>
+    /// The value of the datom
+    /// </summary>
     Type ValueType { get; }
+
+    /// <summary>
+    /// Sends the datom to the sink
+    /// </summary>
+    /// <param name="sink"></param>
+    /// <typeparam name="TSink"></typeparam>
     void Emit<TSink>(ref TSink sink) where TSink : IDatomSink;
 
     /// <summary>
@@ -25,7 +42,7 @@ public interface IDatomWithTx : IDatom
 public class AssertDatom<TAttr, TVal>(ulong e, TVal v) : IDatom
     where TAttr : IAttribute<TVal>
 {
-    public ulong E => e;
+    public ulong Entity => e;
 
     public TVal V => v;
     public Type Attribute => typeof(TAttr);
@@ -70,14 +87,6 @@ public AssertDatomWithTx(ulong e, TVal v, TxId tx) : base(e, v)
 
     public override string ToString()
     {
-        return $"(assert! {E}, {Attribute.Namespace}/{Attribute.Name}, {V}, {Tx})";
-    }
-}
-
-
-public static class Datom {
-    public static IDatom Assert<TAttr, TVal>(ulong e, TVal v) where TAttr : IAttribute<TVal>
-    {
-        return new AssertDatom<TAttr, TVal>(e, v);
+        return $"(assert! {Entity}, {Attribute.Namespace}/{Attribute.Name}, {V}, {Tx})";
     }
 }

src/NexusMods.EventSourcing.Abstractions/IAttribute.cs

@@ -37,11 +37,6 @@ public interface IAttribute
     /// <summary>
     /// Reads the value from the buffer and returns all the data as a Datom
     /// </summary>
-    /// <param name="entity"></param>
-    /// <param name="tx"></param>
-    /// <param name="isAssert"></param>
-    /// <param name="buffer"></param>
-    /// <returns></returns>
     public IDatom Read(ulong entity, ulong tx, bool isAssert, ReadOnlySpan<byte> buffer);
 }
 
@@ -56,17 +51,11 @@ public interface IAttribute<TVal> : IAttribute
     /// <summary>
     /// Reads the value from the buffer and returns the value
     /// </summary>
-    /// <param name="buffer"></param>
-    /// <returns></returns>
     public TVal Read(ReadOnlySpan<byte> buffer);
 
 
     /// <summary>
     /// Creates a new assertion datom for the given entity and value
     /// </summary>
-    /// <param name="tx"></param>
-    /// <param name="entity"></param>
-    /// <param name="value"></param>
     public static abstract void Add(ITransaction tx, EntityId entity, TVal value);
-
 }

src/NexusMods.EventSourcing.Abstractions/IDb.cs

@@ -13,11 +13,6 @@ public interface IDb
     /// </summary>
     TxId BasisTxId { get; }
 
-    public IIterator Where<TAttr>()
-    where TAttr : IAttribute;
-
-    public IIterator Where(EntityId id);
-
     /// <summary>
     /// Returns a read model for each of the given entity ids.
     /// </summary>

src/NexusMods.EventSourcing.Abstractions/Models/IReadModel.cs

@@ -7,5 +7,13 @@
 /// </summary>
 public interface IReadModel
 {
+    /// <summary>
+    /// The entity id of the read model.
+    /// </summary>
     public EntityId Id { get; }
+
+    /// <summary>
+    /// The attached db instance of the read model.
+    /// </summary>
+    public IDb Db { get; }
 }

src/NexusMods.EventSourcing.DatomStore/BuiltInAttributes.cs

@@ -7,10 +7,6 @@ namespace NexusMods.EventSourcing.DatomStore;
 
 public static class BuiltInAttributes
 {
-    public static void AddBuiltInAttributes(this IServiceCollection services) =>
-        services.AddAttribute<UniqueId>()
-            .AddAttribute<ValueSerializerId>();
-
     /// <summary>
     /// The unique identifier of the entity, used to link attributes across application restarts and model changes.
     /// </summary>

src/NexusMods.EventSourcing.DatomStore/BuiltInSerializers/BoolSerializer.cs

@@ -15,13 +15,6 @@ public class BoolSerializer : IValueSerializer<bool>
     /// <inheritdoc />
     public UInt128 UniqueId => Id;
 
-    /// <inheritdoc />
-    public bool TryGetFixedSize(out int size)
-    {
-        size = 1;
-        return true;
-    }
-
     /// <inheritdoc />
     public int Compare(ReadOnlySpan<byte> a, ReadOnlySpan<byte> b)
     {

src/NexusMods.EventSourcing.DatomStore/BuiltInSerializers/UInt128Serializer.cs

@@ -18,13 +18,6 @@ public class UInt128Serializer : IValueSerializer<UInt128>
     /// <inheritdoc />
     public UInt128 UniqueId => Id;
 
-    /// <inheritdoc />
-    public bool TryGetFixedSize(out int size)
-    {
-        size = 16;
-        return true;
-    }
-
     /// <inheritdoc />
     public int Compare(ReadOnlySpan<byte> a, ReadOnlySpan<byte> b)
     {

src/NexusMods.EventSourcing.DatomStore/Indexes/AIndexDefinition.cs

@@ -46,7 +46,7 @@ public void Init(RocksDb db)
         ColumnFamilyHandle = db.CreateColumnFamily(_options, ColumnFamilyName);
     }
 
-    public string ColumnFamilyName { get; } = columnFamilyName;
+    private string ColumnFamilyName { get; } = columnFamilyName;
 
     public void Dispose()
     {
@@ -63,20 +63,8 @@ public void Dispose()
         }
     }
 
-    public static unsafe int Compare(TOuter outer, KeyHeader* a, uint aLength, KeyHeader* b, uint bLength)
-    {
-        throw new NotImplementedException();
-    }
-
     public void Put(WriteBatch batch, ReadOnlySpan<byte> span)
     {
         batch.Put(span, ReadOnlySpan<byte>.Empty, ColumnFamilyHandle);
     }
-
-    public Iterator NewIterator()
-    {
-        var options = new ReadOptions();
-        options.SetTotalOrderSeek(true);
-        return Db.NewIterator(ColumnFamilyHandle, options);
-    }
 }

src/NexusMods.EventSourcing.DatomStore/Indexes/AVTEIndex.cs

@@ -105,7 +105,7 @@ public bool Next()
 
                 _current = (KeyHeader*)Native.Instance.rocksdb_iter_key(_iterator.Handle, out _currentLength);
 
-                Debug.Assert(_currentLength < KeyHeader.Size, "Key length is less than KeyHeader.Size");
+                Debug.Assert(_currentLength >= KeyHeader.Size, "Key length is less than KeyHeader.Size");
 
                 if (_current->AttributeId != _key->AttributeId)
                     return false;

src/NexusMods.EventSourcing.DatomStore/Indexes/EATVIndex.cs

@@ -134,7 +134,7 @@ public bool Next()
 
                 _current = (KeyHeader*)Native.Instance.rocksdb_iter_key(_iterator.Handle, out _currentLength);
 
-                Debug.Assert(_currentLength < KeyHeader.Size, "Key length is less than KeyHeader.Size");
+                Debug.Assert(_currentLength >= KeyHeader.Size, "Key length is less than KeyHeader.Size");
 
                 if (_current->Entity != _key->Entity)
                     return false;