Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passive mode touch events, calms Lighthouse #295

Closed
wants to merge 2 commits into from

Conversation

inoas
Copy link

@inoas inoas commented Apr 10, 2020

Refs:
#291
#289
#267

@coveralls
Copy link

coveralls commented Apr 10, 2020

Coverage Status

Coverage remained the same at 69.88% when pulling 90c433d on inoas:patch-1 into 6eb8440 on Mango:master.

@inoas
Copy link
Author

inoas commented Apr 10, 2020

I am using npm install --save inoas/slideout#patch-1 until this gets merged.

Edit: Somehow npm/node didnt eat the above thing correctly. This works in package.json "slideout": "git://github.com/inoas/slideout.git#patch-1",

Note: You should use your own fork of my fork to be on the safe side, if you go the same route

@inoas
Copy link
Author

inoas commented Apr 10, 2020

@pazguille any chance to merge this rather soon?

@inoas
Copy link
Author

inoas commented Apr 10, 2020

I ran tests, hints, fixed a preexisting CS issue, ran build - now it should be ok.

@inoas
Copy link
Author

inoas commented Apr 13, 2020

@pazguille Do you still in any way maintain this, at least eventually consider some PRs to merge?
That would be so kind.

@inoas
Copy link
Author

inoas commented Apr 20, 2020

Ping @pazguille - hope!

@htstudios
Copy link

Any news?

@paskal
Copy link

paskal commented Dec 29, 2023

@pazguille gentle ping for review and merge.

@inoas
Copy link
Author

inoas commented May 8, 2024

kinda dead.

@inoas inoas closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants