Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix google passive error #267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix google passive error #267

wants to merge 1 commit into from

Conversation

TijmenGraft
Copy link

Google 56 introduced passive mode to default be true. The script will
throw errors

@trdvangraft
Fix google passive error
6fff875 
Google 56 introduced passive mode to default be true. The script will
throw errors
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.88% when pulling 6fff875 on TijmenGraft:master into 6eb8440 on Mango:master.

@andreasroste
Copy link

I support this PR.. get rid of there annoying errors! :)

@joker-777
Copy link

@pazguille Would be great if you could merge this.

nicolaelitvac
nicolaelitvac approved these changes Sep 16, 2019
View reviewed changes
Copy link

@nicolaelitvac nicolaelitvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have this merged to master!

sun
sun approved these changes Nov 9, 2019
View reviewed changes
Copy link

@sun sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether the copy of the script in index.js also needs to be updated:
https://github.com/Mango/slideout/blob/master/index.js#L209
https://github.com/Mango/slideout/blob/master/index.js#L300

sun
sun suggested changes Nov 9, 2019
View reviewed changes
Copy link

@sun sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code primarily needs to be fixed in index.js, the files in dist are compiled.

Also note that this issue has been fixed in v2 in the branch new-features already, but that code hasn't been released in any way yet:
https://github.com/Mango/slideout/compare/new-features#diff-168726dbe96b3ce427e7fedce31bb0bcR237

@inoas
Copy link

inoas commented Apr 10, 2020

Can this be patched for the current stable release so we can improve lighthouse speeds?

inoas added a commit to inoas/slideout that referenced this pull request Apr 10, 2020
@inoas
Add passive mode touch events, calms Lighthouse
3b433df 
Refs:
Mango#291
Mango#289
Mango#267
@inoas inoas mentioned this pull request Apr 10, 2020
Closed
@inoas
Copy link

inoas commented Apr 10, 2020

@sun I have taken over what you suggested in #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sun sun sun requested changes

@nicolaelitvac nicolaelitvac nicolaelitvac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@TijmenGraft @coveralls @andreasroste @joker-777 @inoas @sun @nicolaelitvac @trdvangraft