Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos #9715

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix various typos #9715

wants to merge 4 commits into from

Conversation

luzpaz
Copy link

@luzpaz luzpaz commented Jan 23, 2025

Found via codespell -q 3 -S "*.patch,*.po" -L acount,afile,distroname,parm,serie,synopsys

Found via `codespell -q 3 -S "*.patch,*.po" -L acount,afile,distroname,parm,serie,synopsys`
@chewitt
Copy link
Member

chewitt commented Jan 23, 2025

@luzpaz please change the commit message to treewide: fix typos .. or something that follows package: description format. I'd use treewide or buildsystem for the package name in this case.

@@ -15,7 +15,7 @@ Requires=network-online.service
# 'network-online.service' fails we can not mount and this scripts fails too
After=network-online.service

# usually we mount networks shares because we want they avaible *before* XBMC starts.
# usually we mount networks shares because we want them available *before* XBMC starts.
# so XBMC has access to this mounts from beginning. Note: this slows down the boot!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"so Kodi has access to mounts from the beginning. Note: this slows down boot!"

@@ -15,7 +15,7 @@ Requires=network-online.service
# 'network-online.service' fails we can not mount and this scripts fails too
After=network-online.service

# usually we mount networks shares because we want they avaible *before* XBMC starts.
# usually we mount networks shares because we want them available *before* XBMC starts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same two changes as the smb sample file above

@chewitt
Copy link
Member

chewitt commented Jan 23, 2025

@luzpaz thanks, in reviewing I spotted a couple of extra English manglings in neighbouring line. If you'd be kind enough to address those and the commit message, I'll be happy to merge 👍🏻

@luzpaz
Copy link
Author

luzpaz commented Jan 23, 2025

Sorry for the noise. I'm having ssh issues and i've run out of Github Codespace credits for the month. Would you mind git squashing and --amend'ing the commit as you requested of me?

Copy link
Contributor

@heitbaum heitbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments, all spelling seems to be right and non impacting.

packages/sysutils/systemd/config/system.d/nfs.mount.sample Outdated Show resolved Hide resolved
packages/network/samba/config/samba4-cache.txt Outdated Show resolved Hide resolved
packages/devel/talloc/config/talloc-cache.txt Outdated Show resolved Hide resolved
packages/sysutils/busybox/scripts/fs-resize Show resolved Hide resolved
Copy link
Contributor

@heitbaum heitbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good by me now. Just need to change the commit message and squash the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants