emulation: fix source typo

[luzpaz]

ref: #9715 (comment)

[heitbaum]

I would use the following commit message

• libretro-pcsx-rearmed: fix build for OdroidGoAdvance

note - I think this is dead code. a) We don’t build addons for devices. b) we build ARCH=aarch64 for armv8 targets now. @garbear?

[garbear]

Likely dead code for us. Package was taken from upstream: https://github.com/libretro/Lakka-LibreELEC/blob/Lakka-v6.x/packages/lakka/libretro_cores/pcsx_rearmed/package.mk#L34

[HiassofT]

That OdroidGoAdvance DEVICE seems to have sneaked in with e3b9f5e

We never build anything for this DEVICE (and it's the first time I read about it) so I think that check should just be dropped and the PKG_MAKE_OPTS_TARGET+=" platform=unix" statement from the else clause should be used for ARCH=arm instead

BTW: git grep OdroidGoAdvance shows some more dead code that sneaked in which should be verifyed/dropped as well:

hias@lenny:~/private/libreelec/libreelec-git$ git grep OdroidGoAdvance
packages/emulation/libretro-fbneo/package.mk:  if [ "${PROJECT}" = "Rockchip" -a "${DEVICE}" = "OdroidGoAdvance" ]; then
packages/emulation/libretro-pcsx-rearmed/package.mk:  if [ "${DEVICE}" = "OdroidGoAdvance" ]; then
packages/emulation/libretro-scummvm/package.mk:  if [ "${DEVICE}" = "OdroidGoAdvance" ]; then
packages/emulation/libretro-snes9x/package.mk:if [ "${DEVICE}" = "OdroidGoAdvance" ]; then
packages/emulation/libretro-snes9x2010/package.mk:if [ "${PROJECT}" = "Rockchip" -a "${DEVICE}" = "OdroidGoAdvance" ]; then

[garbear]

Let's remove all the dead code. It's all left over from when I originally ported the cores from Lakka to LE.

[luzpaz]

Since it's deadcode... forgo merging this PR ?