use try with resources in JsonUtil

[pdurbin]

What this PR does / why we need it:

According to Sonarcloud:

"Failure to properly close resources will result in a resource leak which could bring first the application and then perhaps the box the application is on to their knees."

Which issue(s) this PR closes:

• Closes In JsonUtil.java use try-with-resources for return Json.createReader(rdr).readObject(); in method getJsonObject(...) and return Json.createReader(rdr).readArray(); in method getJsonArray(...) #9315

Special notes for your reviewer:

You can see the bug at

https://sonarcloud.io/code?id=IQSS_dataverse&selected=IQSS_dataverse%3Asrc%2Fmain%2Fjava%2Fedu%2Fharvard%2Fiq%2Fdataverse%2Futil%2Fjson%2FJsonUtil.java

Unfortunately, Netbeans didn't flag this error for me locally and therefore didn't offer any kind of automatic fix. Netbeans does seem to have the right rule enabled:

I ended up following https://guides.dataverse.org/en/5.14/developers/tools.html#sonarqube more or less to set up SonarQube and used the following script to test just the one file I was editing:

#!/bin/sh
mvn clean verify sonar:sonar \
  -Dsonar.projectKey=dataverse \
  -Dsonar.projectName='dataverse' \
  -Dsonar.host.url=http://localhost:9000 \
  -Dsonar.sources='src/main/java/edu/harvard/iq/dataverse/util/json/JsonUtil.java' \
  -Dsonar.token=sqp_4a726f4a698d074c795c7c407e100bfa1e81847f

Suggestions on how to test this:

This change is covered by unit tests, so I don't think manual testing is required. However, loading an external tool should test it.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

None. However, we now have an issue about Sonar:

• Set up Sonar #9846

[pdurbin]

I just tried IntelliJ Community 2023.2.1

It was easy to install SonarLint. As shown in the screenshot below this particular "not using try with resources" bug was flagged. In addition, you can right click and analyze just the one file. No auto-fix is offered.

[rtreacy]

looks good

[coveralls]

coverage: 19.971% (+0.002%) from 19.969% when pulling 069bb91 on 9315-jsontry into 62a9811 on develop.

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9315-jsontry

ghcr.io/gdcc/configbaker:9315-jsontry

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.