Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use try with resources in JSONLDUtil #9882

Merged
merged 2 commits into from
Sep 11, 2023
Merged

use try with resources in JSONLDUtil #9882

merged 2 commits into from
Sep 11, 2023

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Sep 6, 2023

What this PR does / why we need it:

According to Sonarcloud:

"Failure to properly close resources will result in a resource leak which could bring first the application and then perhaps the box the application is on to their knees."

Which issue(s) this PR closes:

Special notes for your reviewer:

See #9879 for screenshots and notes about how Netbeans doesn't show this as an error for me. Any tips on getting this working are very welcome.

Suggestions on how to test this:

This is exercised by DatasetsIT. To test manually, use this API endpoint from the Semantic API:

.accept("application/ld+json")
.get("/api/datasets/" + datasetId + "/metadata");

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

None.

@github-actions

This comment has been minimized.

@rtreacy rtreacy self-assigned this Sep 11, 2023
Copy link
Contributor

@rtreacy rtreacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rtreacy rtreacy removed their assignment Sep 11, 2023
@kcondon kcondon self-assigned this Sep 11, 2023
@coveralls
Copy link

coveralls commented Sep 11, 2023

Coverage Status

coverage: 19.969%. remained the same when pulling 9c1819b on 9313-jsonld-try into 62a9811 on develop.

@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9313-jsonld-try
ghcr.io/gdcc/configbaker:9313-jsonld-try

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@kcondon kcondon merged commit 6fee8e5 into develop Sep 11, 2023
11 checks passed
@kcondon kcondon deleted the 9313-jsonld-try branch September 11, 2023 21:21
@pdurbin pdurbin added this to the 6.1 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants