Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single-file-cli 2.0.14 (new cask) #170058

Closed
wants to merge 4 commits into from

Conversation

AngelaDMerkel
Copy link

@AngelaDMerkel AngelaDMerkel commented Mar 27, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Please forgive me. I never use github for anything besides my shit tier personal projects and don't have much of an idea what I am doing. Everything seems to work and all the tests produce no errors, so in theory this should be good to go. As it pertains to the correct repo I have no idea.

@BrewTestBot BrewTestBot added new cask missing zap Cask is missing a zap stanza, please add one. labels Mar 27, 2024
@AngelaDMerkel AngelaDMerkel changed the title single-file-cli 2.0.14 single-file-cli 2.0.14 (new cask) Mar 27, 2024
Replaced the binary with its full name
Updated to include support for x86
@bevanjkay
Copy link
Member

It looks this is an open-source cli-only binary, so you try submitting it as a formula to homebrew-core first.

@AngelaDMerkel
Copy link
Author

It looks this is an open-source cli-only binary, so you try submitting it as a formula to homebrew-core first.

As far as I can tell from the documentation, it's required that the user can build from source. single-file-cli requires Deno and so I assumed wasn't compatible with the requirements for homebrew-core. Can hombrew-core accept only precompiled binaries?

@@ -0,0 +1,12 @@
cask "single-file" do
arch arm: "aarch64-apple-darwin", intel: "x86_64-apple-darwin"
version "2.0.14"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert new line before version, or run brew style --fix single-file.

@SMillerDev
Copy link
Member

single-file-cli requires Deno and so I assumed wasn't compatible with the requirements for homebrew-core.

Deno is open source and can be used to build formula binaries.

@krehel
Copy link
Member

krehel commented Mar 31, 2024

Closing as agreed this should be attempted as a Formula first.

@krehel krehel closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing zap Cask is missing a zap stanza, please add one. new cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants