Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew #71

Open
notDavid opened this issue Mar 26, 2024 · 7 comments
Open

Homebrew #71

notDavid opened this issue Mar 26, 2024 · 7 comments

Comments

@notDavid
Copy link

Hi there,

would be useful to be able to install / update via Homebrew.

Also convenient for people to track this issue to know when it's closed / implemented... :-)

Thank you!

@AngelaDMerkel
Copy link

This will probably have to be a cask as building from source requires Deno. I will see if I can get this working, but I am having an error I have never seen before

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Mar 26, 2024

@AngelaDMerkel Thank you very much. I've never released sofware on Homebrew (and co.). Your help would be really precious. Don't hesitate to ping me if you need any help from me.

@AngelaDMerkel
Copy link

@gildas-lormeau I have no clue what I am doing either and their documentation is pretty poor from my point of view. You can see the pull request here if you want to check on its progress. It looks like it has passed most of the checks.

@AngelaDMerkel
Copy link

@gildas-lormeau Instead of using your precompiled binaries brew has asked me to write a small ruby package definition, which I have done and it successfully builds the single-file binary, but it appears that this binary still depends on single-file-launcher.js which doesn't get moved to homebrew's bin. Am I making a mistake in the compile process, or is it normal that building with Deno results in the need for these secondary files?

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Apr 6, 2024

@AngelaDMerkel That's strange. Could you give me a link to the related code? By the way, thank you again for your work, I read the thread but was a bit overwhelmed by the terms, not being used to homebrew and its ecosystem.

@AngelaDMerkel
Copy link

@gildas-lormeau I've resolved it now, and all the build and run test are passing in my PR Homebrew/homebrew-core#168436

I am not sure they will merge given that I always fail their commit style test. I have no clue what I am doing incorrectly, but hopefully someone will just approve it and it'll be merged

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Apr 10, 2024

@AngelaDMerkel That's a great news :) Did you try to add an explanation for the commit as documented here https://docs.brew.sh/Formula-Cookbook#commit ? The complete commit message could be be for example:

single-file 2.0.29 (new formula)

adds formula for single-file CLI tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants