-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update circle flags #109
Open
kapowaz
wants to merge
13
commits into
HatScripts:gh-pages
Choose a base branch
from
kapowaz:update-circle-flags
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update circle flags #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all circle flags to latest
Fix some broken gallery URLs
Tweak Malta flag
Further tweaks to circle-flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Supersedes #108. I’ve created a new PR based on a specific branch, since I unintentionally used
main
previously. This will let me continue to make other changes to my fork without them appearing in the PR to the base repo. Apologies for the noise!]This might be a controversial PR, but I thought it was worth sharing!
You may be already aware I have created the square-flags project derived from the original circle-flags icons. There are lots of small improvements I’ve made, initially to cater for the square format, but as I made more and more changes I saw opportunities to improve other things besides:
All of this can continue to exist as its own project, but since I created it as a Figma project I was able to take the work and apply a number of these changes back on the circular format. That’s what this PR is all about.
I’ve created an image which shows the difference between the existing flags and the updated versions in this PR, but you can also see the diff per-flag within the PR: