Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circle-flags based on square-flags project #108

Closed
wants to merge 8 commits into from

Conversation

kapowaz
Copy link

@kapowaz kapowaz commented Nov 2, 2023

This might be a controversial PR, but I thought it was worth sharing!

You may be already aware I have created the square-flags project derived from the original circle-flags icons. There are lots of small improvements I’ve made, initially to cater for the square format, but as I made more and more changes I saw opportunities to improve other things besides:

  • Use the navy colour for flags that are more obviously navy than royal blue (e.g. Australia)
  • Add a darker yellow that has better contrast with lighter shades, and updated various elements to use it
  • Improved alignment with the pixel grid for various stripes and crosses etc.
  • Improved alignment of details in corners of flags (e.g. Georgia) so as to work better with a square background
  • Fixed smaller details on some flags that seemed overly minimalist (e.g. India, Iran)

All of this can continue to exist as its own project, but since I created it as a Figma project I was able to take the work and apply a number of these changes back on the circular format. That’s what this PR is all about.

I’ve created an image which shows the difference between the existing flags and the updated versions in this PR, but you can also see the diff per-flag within the PR:

circle-flags-diff

@HatScripts HatScripts added the enhancement New feature or request label Nov 3, 2023
@kapowaz
Copy link
Author

kapowaz commented Nov 4, 2023

Closing this in favour of #109.

@kapowaz kapowaz closed this Nov 4, 2023
@waldyrious waldyrious mentioned this pull request Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants