Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update scalar deps #2304

Closed
wants to merge 3 commits into from
Closed

feat: update scalar deps #2304

wants to merge 3 commits into from

Conversation

emmerich
Copy link
Contributor

@emmerich emmerich commented May 1, 2024

Reopening #2303

@@ -98,7 +98,10 @@ export function ScalarApiClient(props: { children: React.ReactNode }) {
{
url: operationData.path,
},
getRequestFromOperation(operation, { requiredOnly: false }),
getRequestFromOperation(
{ ...operation, information: operationData.operation },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marclave There might be some incompleteness on typing here:

Screenshot 2024-05-01 at 15 25 54

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! let me fix this : )

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmerich
Copy link
Contributor Author

Closing in favour of #2310

@emmerich emmerich closed this May 14, 2024
Copy link

argos-ci bot commented May 14, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 12 changed May 14, 2024, 10:06 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants