Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update scalar deps #2303

Closed
wants to merge 3 commits into from
Closed

feat: update scalar deps #2303

wants to merge 3 commits into from

Conversation

marclave
Copy link
Collaborator

@marclave marclave commented Apr 26, 2024 •
edited

In this PR we:

  • updated the scalar dependencies (api-client)
  • this included our new theming changes - while they are backwards compatible, we updated to the new scalar-variables. This was done to avoid collisions with users already using --theme-variables
  • fixed the body auto populating fields bug

emmerich
emmerich approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@emmerich emmerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, our repo doesn't look correctly configured to run workflows on PRs from forks but hopefully this approval will fix that.

@emmerich emmerich mentioned this pull request May 1, 2024
Closed
@emmerich
Copy link
Contributor

emmerich commented May 1, 2024

Argh, looks like the repo is not correctly configured to handle pull_request events (which would allow forks to run actions). It's running on push. I'd change it but it'd also affect how we release the code.

In the meantime I've re-opened your PR in the repo here: #2304

@emmerich emmerich closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmerich emmerich emmerich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marclave @emmerich