Fix for some CRAM 3.1 codecs failing to parse #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
htscodecs_merge
branch
from
1a1e74d to
4a88867
Compare
|
can confirm by using "git checkout master; git checkout htscodecs_merge test; yarn test" (get the test files from this branch) that the level 4 cram3.1 codec test fails on master and succeeds on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
a) vendors (copies into this repo) @jkbonfield/htscodecs npm package
b) applies bugfix observed for this package to this copy jkbonfield/htscodecs#1
c) adds cram 3.1 test files