Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with CRAM 3.1 files #141

Closed
cmdcolin opened this issue Sep 25, 2024 · 4 comments
Closed

Ensure compatibility with CRAM 3.1 files #141

cmdcolin opened this issue Sep 25, 2024 · 4 comments

Comments

@cmdcolin
Copy link
Contributor

cmdcolin commented Sep 25, 2024

samtools announced that their current version is the last version that will only output CRAM 3.0, next versions will be CRAM 3.1. We should test that we can accomodate 3.1 files

See "This is the last SAMtools / HTSlib release where CRAM 3.0 will be the default CRAM version. From the next we will change to CRAM 3.1 unless the version is explicitly specified, for example using samtools view -O cram,version=3.0." https://github.com/samtools/samtools/releases/tag/1.21

@cmdcolin
Copy link
Contributor Author

initial testing found at least one possible fail, possible patch with htscodecs PR here jkbonfield/htscodecs#1

@cmdcolin
Copy link
Contributor Author

cmdcolin commented Nov 8, 2024

cc @jrobinso there was a fix for some CRAM 3.1 files in new cram-js release v3.0.7.

at least one file from the hts-specs test ("level4.cram") was failing in previous cram-js versions (https://github.com/samtools/hts-specs/tree/master/test/cram/3.1/passed)

i wanted to make sure cram 3.1 was supported since samtools release docs said they're making it on by default soon "https://github.com/samtools/samtools/releases"

@cmdcolin cmdcolin closed this as completed Nov 8, 2024
@cmdcolin
Copy link
Contributor Author

cmdcolin commented Nov 8, 2024

fixed by this PR #144

@jrobinso
Copy link
Contributor

jrobinso commented Nov 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants