Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from threading.Lock() to django-db-mutex #170

Closed
wants to merge 2 commits into from
Closed

Migrate from threading.Lock() to django-db-mutex #170

wants to merge 2 commits into from

Conversation

timobrembeck
Copy link
Contributor

Fixes #168

@timobrembeck timobrembeck force-pushed the django-db-mutex branch 4 times, most recently from 2b09376 to 142bcbb Compare February 27, 2023 13:33
@claudep
Copy link
Contributor

claudep commented Mar 19, 2023

I'd like to have a release before deciding about the future of this PR.

@timobrembeck timobrembeck marked this pull request as draft March 26, 2023 21:49
@timobrembeck
Copy link
Contributor Author

@claudep We have been using django-db-mutex for a few weeks now in our project and did not see a reduction in race conditions (see digitalfabrik/integreat-cms#1518), so I would put this PR on hold.
I'm not sure whether it's really a problem with the library of if we're just using it wrong, but I would only want to merge this PR if we can be really certain it fixes the issue.

Other than that, would you mind releasing the current master branch? As far as I can tell, this only has advantages and no breaking changes. Thanks a lot in advance! 🙏

@timobrembeck
Copy link
Contributor Author

I don't understand why, but django-db-mutex does not prevent race conditions as I expected.
I'm going to close this and search for alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update_lock not race-condition-safe
2 participants
@timobrembeck @claudep