Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed lightbox issue with alignment control #4297

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Fixed lightbox issue with alignment control #4297

merged 3 commits into from
Oct 28, 2024

Conversation

girishpanchal30
Copy link
Contributor

Summary

Fixed issue with WP default lightbox model.

Test instructions

  1. Add an image block
  2. enable “Expand on click” for the image
  3. change the alignment of the image ( left/right/center) -> when an alignment option (other than None ) is enabled, the image doesn't expand to full width

Check before Pull Request is ready:

Closes #4260

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 2, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 2, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Sep 2, 2024 •
edited
Loading

Plugin build for 9afa3f4 is ready 🛎️!

@girishpanchal30 girishpanchal30 mentioned this pull request Sep 2, 2024
Closed
@rodica-andronache
Copy link
Contributor

tested and it's working well 👍

@selul
Copy link
Contributor

selul commented Sep 2, 2024

@girishpanchal30 we are not looking to increase the CSS limit so please review the solution within the boundaries.

@girishpanchal30
Copy link
Contributor Author

@selul I've added an inline style instead of adding CSS in the main style.

@rodica-andronache
Copy link
Contributor

tested and it's still working

@vytisbulkevicius vytisbulkevicius merged commit cd84333 into development Oct 28, 2024
16 checks passed
@vytisbulkevicius vytisbulkevicius deleted the bugfix/4260 branch October 28, 2024 12:21
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soare-Robert-Daniel Soare-Robert-Daniel Soare-Robert-Daniel approved these changes

Assignees
No one assigned
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@girishpanchal30 @pirate-bot @rodica-andronache @selul @ineagu @Soare-Robert-Daniel @vytisbulkevicius